Uploaded image for project: 'Confluence Data Center'
  1. Confluence Data Center
  2. CONFSERVER-25394

Macros don't support absolute icon urls

    XMLWordPrintable

Details

    Description

      The macro configuration supports absolute urls to icons and in fact, it does work sometimes, like when the autocomplete tries to suggest a macro. However, once you open up the macro editor, an NPE is thrown as it expects the icon url to be relative.

      The specific problem is in MacroMetadataParser line 164:

              if (icon != null)
              {
                  builder.setIcon(new MacroIcon(icon, true));
              }
      

      Notice it always treats the icon as relative (isRelative is the second argument), while elsewhere in the code it property detects an absolute url based on whether it starts with http.

      Attachments

        Issue Links

          Activity

            People

              richatkins Richard Atkins
              dbrown@atlassian.com Don Brown (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: