Uploaded image for project: 'Confluence Data Center'
  1. Confluence Data Center
  2. CONFSERVER-19947

atlassian-plugin.xml: trim white spaces

XMLWordPrintable

      The following snippet will cause Confluence not to find the velocity templates:

          <xwork key="space-admin-actions" name="Scroll Space Template Actions">
        <package name="Scroll Admin Actions" extends="spaces" namespace="/spaces/com.k15t.scroll.office">
            <default-interceptor-ref name="defaultStack"/>
            <action name="templates" class="com.k15t.scroll.office.web.admin.SpacesTemplatesAction" method="action">
                <result name="success" type="velocity">/com/k15t/scroll/office/templates/admin/templates-spaces.vm
                </result>
                <result name="error" type="velocity">/com/k15t/scroll/office/templates/admin/templates-spaces.vm
                </result>
                <result name="none" type="redirect">/spaces/com.k15t.scroll.office/templates.action?key=${space.Key}
                </result>
            </action>
        </package>
    </xwork>

      It would be nice if you could trim the whitespace, as idea will introduce the white-spaces on code-formatting.

            [CONFSERVER-19947] atlassian-plugin.xml: trim white spaces

            Stefan Kleineikenscheidt (K15t) added a comment -

            Great, thanks for that! Grüße from Germany, -Stefan

            Stefan Kleineikenscheidt (K15t) added a comment - Great, thanks for that! Grüße from Germany, -Stefan

            Ryan added a comment -

            Thanks Stefan, I just wanted to confirm

            The fix for this is in 3.3-beta3.

            Cheers,

            Ryan Thomas

            Ryan added a comment - Thanks Stefan, I just wanted to confirm The fix for this is in 3.3-beta3. Cheers, Ryan Thomas

            Stefan Kleineikenscheidt (K15t) added a comment -

            Ryan, yes of cours - it works. The problem is when you hit alt-cmd-l and reformat the atlassian-plugin.xml it will stop working.

            Stefan Kleineikenscheidt (K15t) added a comment - Ryan, yes of cours - it works. The problem is when you hit alt-cmd-l and reformat the atlassian-plugin.xml it will stop working.

            Daniel (Inactive) added a comment -

            at the very minimum log the throwable. Just silently swallowing it is not good. Preferrably catch the expected exceptions, and handle them appropriately.

            Daniel (Inactive) added a comment - at the very minimum log the throwable. Just silently swallowing it is not good. Preferrably catch the expected exceptions, and handle them appropriately.

            Ryan added a comment -

            Hi Stefan, are you able to verify that this plugin works when the whitespace is removed?

            Cheers,

            Ryan Thomas

            Ryan added a comment - Hi Stefan, are you able to verify that this plugin works when the whitespace is removed? Cheers, Ryan Thomas

              rthomas@atlassian.com Ryan
              b4d715caa01f Stefan Kleineikenscheidt (K15t)
              Affected customers:
              0 This affects my team
              Watchers:
              0 Start watching this issue

                Created:
                Updated:
                Resolved: