Uploaded image for project: 'Confluence Data Center'
  1. Confluence Data Center
  2. CONFSERVER-18073

Cache result of isSuperUser check in permission handling

    XMLWordPrintable

Details

    • We collect Confluence feedback from various sources, and we evaluate what we've collected when planning our product roadmap. To understand how this piece of feedback will be reviewed, see our Implementation of New Features Policy.

    Description

      If you run Confluence without user property caching, it does around twenty database hits per request to check whether the current user is disabled or not. This is the deactivated check in UserAccessor.isSuperUser() method, which gets called for most permission checks in Confluence.

      We should cache the result of this check for each request so we only need to check whether the user is disabled once.

      This fix will involve moving the isSuperUser check into the PermissionManager so that we don't need to add caching in all the calling code or in the UserAccessor which currently has none.

      Attachments

        Issue Links

          Activity

            People

              matt@atlassian.com Matt Ryall
              matt@atlassian.com Matt Ryall
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: