Uploaded image for project: 'Confluence Data Center'
  1. Confluence Data Center
  2. CONFSERVER-16058

CreateRssFeedAction doesn't handle multiple RSS types in request nicely

      I'm seeing several of these in the EAC logs:

      [com.opensymphony.xwork.DefaultActionInvocation.executeResult] No result defined for action com.atlassian.confluence.spaces.actions.CreateRssFeedAction and result rss2, atom, atom
      

      along with access :

      "GET /createrssfeed.action?types=blogpost&sort=created&showContent=true&spaces=PS&labelString%3D&rssType=rss2&maxResults=20&timeSpan=7&publicFeed=false&title=Blogs+Only&showDiff=false&os_authType=basic%3D&rssType=atom&maxResults=20&timeSpan=7&publicFeed=fals
      e&title=TST+Blogs+Only&showDiff=false&os_authType=basic%3D&rssType=atom&maxResults=20&timeSpan=7&publicFeed=false&title=TST+Blogs+Only&showDiff=false&os_authType=basic HTTP/1.1" 401 954 "-" "Apple-PubSub/65.6.3" 3556
      

      A 401 is being returned as a result of the XWork result failure but it should be picking up that the request has three rssTypes (rss2, atom, atom in that order) which is invalid and should thus return a 400.

      If we stop the XWork WARN we stop log spam : )

          Form Name

            [CONFSERVER-16058] CreateRssFeedAction doesn't handle multiple RSS types in request nicely

            added 3.2 fix-for-version so it shows up in official 3.2 issues list

            Per Fragemann [Atlassian] added a comment - added 3.2 fix-for-version so it shows up in official 3.2 issues list

            Ryan added a comment -

            Added test to rssType to see if there are comma deliminated values in the member, return default rss type if this is true.

            Ryan added a comment - Added test to rssType to see if there are comma deliminated values in the member, return default rss type if this is true.

              rthomas@atlassian.com Ryan
              dtaylor David Taylor (Inactive)
              Affected customers:
              0 This affects my team
              Watchers:
              0 Start watching this issue

                Created:
                Updated:
                Resolved: