Uploaded image for project: 'Confluence Cloud'
  1. Confluence Cloud
  2. CONFCLOUD-73259

Star button missing aria-pressed attribute

    XMLWordPrintable

Details

    Description

      Issue Summary

      The star this page button should have the `aria-pressed` attribute

      https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-pressed

      missing here: /wiki/home/recent

      Looks like that component is used elsewhere too

      Other bugs:

      • aria-label should go on the button, not the nested span
      • buttons are already interactive and should not need the tabindex=0 value
      • buttons do not need type=button, that is the default already
      • Why is role='presentation' wrapping the button (parent element)?
      • There is an unnecessary div between role=presentation and button .. trying using React.Fragment instead

      Steps to Reproduce

      1. View star button in recents component
      2. Step 2

      Expected Results

      Button has aria-pressed attribute

      Actual Results

      missing attribute, our customers using screen readers won't know it is a toggle

      The below exception is thrown in the xxxxxxx.log file:

      ...
      

      Workaround

      Currently there is no known workaround for this behavior. A workaround will be added here when available

      Attachments

        Activity

          People

            Unassigned Unassigned
            ttadej Tyler T
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: