Unable to use "Share a Link" functionality of Share Link blueprint if user has access to a single space and that space is a favourite

Summary

Part of the Share Link blueprint is a bookmarklet that links the user to /wiki/plugins/sharelinksbookmarklet/bookmarklet.action?bookmarkedURL=<URL-encoded URL>. If all the spaces the Confluence user has access to are marked as favorite, instead of seeing the "Share a Link" page they'll see an error saying "You are not allowed to share on this Confluence".

Steps to reproduce

1. Give a user access to one single space in Confluence
   • This happens with multiple spaces as well, as long as they are all marked as favorite in step 3
2. Log in as that user
3. Add the space as a favourite
4. Go the Share a Link URL above (/wiki/plugins/sharelinksbookmarklet/bookmarklet.action?bookmarkedURL=<URL-encoded URL>).

Notes

This seems to be caused by favourite spaces being explicitly removed from the list of spaces that the Share a Link dialog checks against, in BookmarkletAction.java:

        // favourite spaces shouldn't appear in the global list as
        globalSpaces.removeAll(favouriteSpaces);

The comment there isn't cut off by me, that's what it says in the source itself.

Workaround

Either give this user access to another space not marked as favorite or 'unfavorite' the space.