Uploaded image for project: 'Clover'
  1. Clover
  2. CLOV-1431

JDK8 sources fail to compile when instrumented by Clover

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Medium Medium
    • 3.2.2
    • None
    • Instrumentation
    • None

      See the attached comparison of original and instrumented code:

      unicode_decoding_error.png

      A problem is as follows:

      • Clover has a UnicodeDecodingReader class which translates 6-letter character sequences "\uNNNN" into a single UTF16 character
      • this is used to correctly tokenize code identifiers (IDENT) written in non-ascii characters (a variable with German umlaut for instance)

      In this specific example, some "\uNNNN" sequences were translated inside comments, and some characters were "swallowed". So for instance a fragment:

      {@code \u}

      ends with "java: illegal unicode escape".

      Related issues:

      • CLOV-1305 - syntax highlighting problem
      • CLOV-1131 - Eclipse/IDEA editors get out of sync

        1. unicode_decoding_error.png
          unicode_decoding_error.png
          133 kB

          Form Name

            [CLOV-1431] JDK8 sources fail to compile when instrumented by Clover

            Marek Parfianowicz made changes -
            Remote Link Original: This issue links to "Page (Extranet)" [ 73385 ]
            Owen made changes -
            Workflow Original: New Clover Workflow [ 898251 ] New: New Clover Workflow - Restricted [ 1475212 ]
            Piotr Swiecicki made changes -
            Workflow Original: Clover Workflow [ 896623 ] New: New Clover Workflow [ 898251 ]
            Piotr Swiecicki made changes -
            Workflow Original: reviewflow [ 619497 ] New: Clover Workflow [ 896623 ]
            Marek Parfianowicz made changes -
            Remote Link Original: This issue links to "Page (Extranet)" [ 73385 ] New: This issue links to "Page (Extranet)" [ 73385 ]
            Marek Parfianowicz made changes -
            Remote Link Original: This issue links to "Page (Extranet)" [ 73385 ] New: This issue links to "Page (Extranet)" [ 73385 ]
            Marek Parfianowicz made changes -
            Remote Link New: This issue links to "Page (Extranet)" [ 73385 ]
            Marek Parfianowicz made changes -
            Status Original: Resolved [ 5 ] New: Closed [ 6 ]
            Marek Parfianowicz made changes -
            Resolution New: Fixed [ 1 ]
            Status Original: To be reviewed [ 10026 ] New: Resolved [ 5 ]
            Marek Parfianowicz made changes -
            Status Original: Implemented [ 10025 ] New: To be reviewed [ 10026 ]

              mparfianowicz Marek Parfianowicz
              mparfianowicz Marek Parfianowicz
              Affected customers:
              0 This affects my team
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: