[CLOV-1131] Unicode CR/LF characters in javadoc causes Eclipse/IntelliJ editors get out of sync

Type: Bug
Resolution: Fixed
Priority: Medium
Fix Version/s: 3.2.2
Affects Version/s: 3.1.6
Component/s: CEP Plugin, CIJ Plugin, Instrumentation
Labels:
None

Try the following example:

class Unicode {   
    void foo() {
    	System.out.println("1");
    	/** {@code \u000a} LF */
    }
    
    
    
    void goo() {
    	System.out.println("2");    	
    	/** {@code \u000d} CR */
    }
    
    
    
    void hoo() {
    	System.out.println("3");
    }
    
    
    
} // end

In Eclipse editor, every CR/LF written in unicode causes that it interprets it as newline character. As a result left ruler "sees" more lines and all subsequent coverage blocks are shifted down.

In IntelliJ it's even worse, as we get exception. Stack trace:

Error during dispatching of java.awt.event.InvocationEvent[INVOCATION_DEFAULT,runnable=com.cenqua.clover.idea.content.ContentPlugin$1@789e7511,notifier=null,catchExceptions=false,when=1343648365649] on sun.awt.windows.WToolkit@2018aa27: Wrong end: 270; document length=249; start=246
java.lang.IllegalArgumentException: Wrong end: 270; document length=249; start=246
	at com.intellij.openapi.editor.impl.RangeMarkerImpl.<init>(RangeMarkerImpl.java:47)
	at com.intellij.openapi.editor.impl.DocumentImpl.createRangeMarker(DocumentImpl.java:303)
	at com.intellij.openapi.editor.impl.RangeHighlighterImpl.<init>(RangeHighlighterImpl.java:58)
	at com.intellij.openapi.editor.impl.MarkupModelImpl.a(MarkupModelImpl.java:119)
	at com.intellij.openapi.editor.impl.MarkupModelImpl.addRangeHighlighter(MarkupModelImpl.java:135)
	at com.cenqua.clover.idea.content.DocMarkupPlugin$HighlightMarkupBuilder.highlightStatement(DocMarkupPlugin.java:286)
	at com.cenqua.clover.idea.content.DocMarkupPlugin$HighlightMarkupBuilder.process(DocMarkupPlugin.java:220)
	at com.cenqua.clover.idea.content.DocMarkupPlugin.updateMarkups(DocMarkupPlugin.java:136)
	at com.cenqua.clover.idea.content.DocMarkupPlugin.refresh(DocMarkupPlugin.java:424)
	at com.cenqua.clover.idea.content.ContentPlugin$1.run(ContentPlugin.java:96)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:209)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:646)
	at java.awt.EventQueue.access$000(EventQueue.java:84)
	at java.awt.EventQueue$1.run(EventQueue.java:607)
	at java.awt.EventQueue$1.run(EventQueue.java:605)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:616)
	at com.intellij.ide.IdeEventQueue.f(IdeEventQueue.java:627)
	at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:508)
	at com.intellij.ide.IdeEventQueue.b(IdeEventQueue.java:405)
	at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:369)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List

Unicode.png
13 kB
30/Jul/2012 11:51 AM

is related to

CLOV-1431 JDK8 sources fail to compile when instrumented by Clover

Closed

Owen made changes - 07/Jul/2016 5:15 AM

Workflow

Original: New Clover Workflow [ 897593 ]

New: New Clover Workflow - Restricted [ 1474296 ]

Piotr Swiecicki made changes - 10/Jun/2015 10:53 AM

Workflow

Original: Clover Workflow [ 895218 ]

New: New Clover Workflow [ 897593 ]

Piotr Swiecicki made changes - 10/Jun/2015 10:29 AM

Workflow

Original: reviewflow [ 398502 ]

New: Clover Workflow [ 895218 ]

Marek Parfianowicz made changes - 07/Feb/2014 8:48 AM

Component/s

New: Instrumentation [ 12549 ]

Marek Parfianowicz made changes - 05/Feb/2014 1:48 PM

Fix Version/s		New: 3.2.2 [ 38092 ]
Fix Version/s	Original: 4.1.2 [ 28194 ]
Resolution		New: Fixed [ 1 ]
Status	Original: Open [ 1 ]	New: Closed [ 6 ]

Marek Parfianowicz added a comment - 05/Feb/2014 1:40 PM

Fixed by ~~CLOV-1431~~

Marek Parfianowicz added a comment - 05/Feb/2014 1:40 PM Fixed by CLOV-1431

Marek Parfianowicz made changes - 17/Jan/2014 10:03 AM

Link

New: This issue is related to ~~CLOV-1431~~ [ ~~CLOV-1431~~ ]

Marek Parfianowicz added a comment - 06/Nov/2013 12:29 PM

It's probably related with a UnicodeDecodingReader on the instrumentation level.

Marek Parfianowicz added a comment - 06/Nov/2013 12:29 PM It's probably related with a UnicodeDecodingReader on the instrumentation level.

Marek Parfianowicz made changes - 19/Oct/2012 11:59 AM

Fix Version/s		New: 3.1.11 [ 28194 ]
Fix Version/s	Original: 3.1.9 [ 26217 ]

Marek Parfianowicz made changes - 30/Jul/2012 11:51 AM

Attachment

New: Unicode.png [ 69134 ]

Assignee:: Marek Parfianowicz

Reporter:: Marek Parfianowicz

Affected customers:: 0 This affects my team

Watchers:: 1 Start watching this issue

Created:: 30/Jul/2012 11:49 AM

Updated:: 07/Feb/2014 8:48 AM

Resolved:: 05/Feb/2014 1:48 PM

Estimated:

16h

Remaining:

16h

Logged:

Not Specified

Details

Description

Attachments

Attachments

Issue Links

Forms

Activity

Collapse comment: Marek Parfianowicz added a comment - 05/Feb/2014 1:40 PM

Expand comment: Marek Parfianowicz added a comment - 05/Feb/2014 1:40 PM

Collapse comment: Marek Parfianowicz added a comment - 06/Nov/2013 12:29 PM

Expand comment: Marek Parfianowicz added a comment - 06/Nov/2013 12:29 PM

People

Dates

Time Tracking