-
Bug
-
Resolution: Fixed
-
High
-
None
-
None
-
Severity 2 - Major
-
(not that you are in the commit diff for 06e4424d336)
try to expand above 479/450
should see: https://stash.dev.internal.atlassian.com/projects/STASH/repos/stash/browse/plugins/importer/src/main/resources/static/import-form/import-form.js?until=ba1274bf482e71980966a9eda9f772cf6d570275&untilPath=plugins%2Fimporter%2Fsrc%2Fmain%2Fresources%2Fstatic%2Fimport-form%2Fimport-form.js&at=refs%2Fheads%2Fbugfix%2FBSERVDEV-13744-js-testing#468-501
actually see: https://stash.dev.internal.atlassian.com/projects/STASH/repos/stash/browse/plugins/importer/src/main/resources/static/import-form/import-form.js?until=ba1274bf482e71980966a9eda9f772cf6d570275&untilPath=plugins%2Fimporter%2Fsrc%2Fmain%2Fresources%2Fstatic%2Fimport-form%2Fimport-form.js&at=refs%2Fheads%2Fbugfix%2FBSERVDEV-13744-js-testing#502-513
Bryan said "Looks like it's using the since line numbers but the until commit ID"
| Form Name | |||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
[BSERV-9126] "See more" shows wrong code from a commit review
BSERV-7263 flips the ref that is used for expanding context to fix the Compare page. But this gets the line numbers wrong on the Commit diffs. Does it also get the lines wrong on the Compare page? I need to double check. If so, we can fix both of those at once by using a different set of line numbers in that case. Otherwise, I have to understand why it would be working for Compare, but not for commit diffs.
Just tried it on the Compare page, and it's equally wrong. https://stash.dev.internal.atlassian.com/projects/STASH/repos/bitbucket-analytics-queries/pull-requests?create&targetBranch=refs%2Fheads%2Fmaster&sourceBranch=refs%2Fheads%2Fprod-filter-and-wallboard-metrics&targetRepoId=9657#README.md
So I just need to fix the line numbers in both places.