SSH field is blank in clone dialog when SSH plugin doesn't start on mirror

Summary

In case the SSH server does not start up, the SSH field is blank in the clone dialog.

This can be confirmed by running netstat on the Bitbucket Server mirror server and confirming that it is not listening port 7999.

Environment

• Bitbucket Datacenter and a mirror instance.

Steps to Reproduce

1. Set up a Bitbucket Server Data Center instance
2. Set up a mirror
3. Block the port 7999 from being reached in case you can't reproduce the SSH plugin failure on startup (i.e. BSERV-8345)

Alternatively, you might be able to block the SSH plugin from starting up by cat /dev/random to a file or /dev/null before starting BbS.

Expected Results

A clear error message indicating that SSH is not working properly should be shown.

Actual Results

We show an empty URL for SSH, instead. See image below:

Workaround

If you're hitting this, probably your SSH server plugin is not starting for some reason. Please follow workarounds described on BSERV-8345 accordingly.

Suggested fix

We discussed making the SSH plugin required and Johnsoning BbS if it fails to start up.