Uploaded image for project: 'Bitbucket Data Center'
  1. Bitbucket Data Center
  2. BSERV-8301

Stash's comments mangle NSString literals and other @-prefixed things (@"foo" is rendered as @foo)

    XMLWordPrintable

Details

    • We collect Bitbucket feedback from various sources, and we evaluate what we've collected when planning our product roadmap. To understand how this piece of feedback will be reviewed, see our Implementation of New Features Policy.

    Description

      If I add a comment in Stash’s code review interface that contains something like this:
      [csMutable addCharactersInString:@"-"];

      It turns it into this:
      [csMutable addCharactersInString:@-];

      And if I try doing something more complicated, like this:
      @[@“foo”, @“bar”, @“baz”];

      It results in a comment like this:
      @[@foo, @bar, @baz];

      This is really annoying and makes code review of Obj-C sources a real pain.

      Attachments

        Issue Links

          Activity

            People

              rstocker Robin Stocker (Inactive)
              4c762d6af390 Corey Steele
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: