Uploaded image for project: 'Bitbucket Data Center'
  1. Bitbucket Data Center
  2. BSERV-7920

File tree doesn't work with Firefox 41 or greater when invalid URL characters in filenames

    XMLWordPrintable

Details

    Description

      NOTE: This issue affects all versions of Bitbucket Server and Stash.

      Cause

      Firefox 41 introduced a change to their encoding handling of URL hashes. When given a value, they now encode it if required, but don't decode it again when the value is read back out. This causes our file tree to mismatch the hash against the file name and fail to find the selected file since it is comparing the decoded version against the encoded one.

      Workaround

      If you are comfortable setting flags in your browser, you can set dom.url.getters_decode_hash to true as a temporary workaround. This flag can be set by visiting the URL "about:config", confirming that you understand the implications, searching for "dom.url.getters_decode_hash", and double-clicking the false value cell. NOTE: once the issue is fixed in Bitbucket Server, you will have to set this flag back to false to avoid seeing similar errors with filenames that are already percent-encoded.

      The newest stable version of Firefox (41) can't switch files in a commit or pull request file tree when one of the files contains spaces.

      Steps to reproduce:

      1. Visit a commit or pull request page that contains files with spaces in the name (or in the directory)
      3. Select the second or further file

      Expected:
      The selected file is shown in the content

      Actual:
      The first file is shown, but the URL reflects the file you clicked.

      Attachments

        Issue Links

          Activity

            People

              khughes@atlassian.com Kristy
              aahmed Adam Ahmed (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: