Uploaded image for project: 'Bitbucket Data Center'
  1. Bitbucket Data Center
  2. BSERV-7610

Typing in comment of diff view is slow and causes heavy CPU use

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Medium Medium
    • 4.8.0
    • 3.10.0
    • None

      In Firefox:

      1. In a diff view, add a line comment
      2. Type text really fast™

      Expected: Text appears instantly
      Actual: It appears with some lag (the more you type the longer it lags behind). If no lag is noticeably, check out the CPU usage.

        1. call-tree.png
          call-tree.png
          200 kB
        2. flame-chart.png
          flame-chart.png
          95 kB

            [BSERV-7610] Typing in comment of diff view is slow and causes heavy CPU use

            nemmersonkellyac added a comment -

            I think this is now tracked in BSERV-12580 

            nemmersonkellyac added a comment - I think this is now tracked in  BSERV-12580  

            Bailey Waldorf added a comment -

            We are seeing the same on 7.2.4

            Bailey Waldorf added a comment - We are seeing the same on 7.2.4

            Dana Cartwright added a comment -

            We are also observing the same issue, also on v7.3.1. Should this be re-opened or a new issue created?

            Dana Cartwright added a comment - We are also observing the same issue, also on v7.3.1. Should this be re-opened or a new issue created?

            Patrick Little added a comment -

            We are observing the same described lag on v7.3.1

            Patrick Little added a comment - We are observing the same described lag on v7.3.1

            Marcin added a comment -

            The performance when typing in comments and tasks has been improved for 4.8.0 by reducing the number of unnecessary resize events fired by the textarea controls which were triggering expensive reflows and other CodeMirror events when the size of the textarea hadn't actually changed.

            Marcin added a comment - The performance when typing in comments and tasks has been improved for 4.8.0 by reducing the number of unnecessary resize events fired by the textarea controls which were triggering expensive reflows and other CodeMirror events when the size of the textarea hadn't actually changed.

            dabrahams added a comment - - edited

            The time seems to grow exponentially with reply depth in a string of replies-to-replies-to-replies in a large diff window. I was waiting 5 seconds per character just now (in stash v3.9.2)

            You should raise the priority of this issue! That's not "minor", that's unusable.

            dabrahams added a comment - - edited The time seems to grow exponentially with reply depth in a string of replies-to-replies-to-replies in a large diff window. I was waiting 5 seconds per character just now (in stash v3.9.2) You should raise the priority of this issue! That's not "minor", that's unusable .

            Michael McGlynn (Inactive) added a comment -

            Thanks for the extra info.

            Michael McGlynn (Inactive) added a comment - Thanks for the extra info.

            Andrew Herron added a comment -

            I'm currently on 8.0.7 (OS X 10.10.4) but I've been seeing it for a while. When I first saw it I thought about reporting it, but 5416 had already been logged.

            Andrew Herron added a comment - I'm currently on 8.0.7 (OS X 10.10.4) but I've been seeing it for a while. When I first saw it I thought about reporting it, but 5416 had already been logged.

            Michael McGlynn (Inactive) added a comment -

            andrew.herron@ephox.com, which version of Safari are you using?

            Michael McGlynn (Inactive) added a comment - andrew.herron@ephox.com , which version of Safari are you using?

            Andrew Herron added a comment -

            This is very noticeable on Safari (i.e. STASH-5416). It's related to the size of the browser window. At full screen size on a 27" display, typing a comment in diff view (or pull request view if there are a lot of existing comments) can easily take half a second per character or longer to appear.

            Andrew Herron added a comment - This is very noticeable on Safari (i.e. STASH-5416 ). It's related to the size of the browser window. At full screen size on a 27" display, typing a comment in diff view (or pull request view if there are a lot of existing comments) can easily take half a second per character or longer to appear.

              mszczepanski Marcin
              rstocker Robin Stocker (Inactive)
              Affected customers:
              4 This affects my team
              Watchers:
              12 Start watching this issue

                Created:
                Updated:
                Resolved: