Details
-
Bug
-
Resolution: Fixed
-
Low
-
None
Description
While reviewing a pull request, I noticed that when I hover the mouse over the [Approve] button in the upper right corner of the web page, it displays the following tool tip text:
Approve this pull request (Type 'a')
Nice to have a hot key to approve!
I would first recommend lowercasing "Type"; as a result, the tool tip text would read as follows:
Approve this pull request (type 'a')
When I hover the mouse over the [Approve] button after having approved the pull request, the tool tip text now reads as follows:
You have approved this pull request (Type 'a')
At first, I was going to recommend removing the text "(Type 'a')" from the end of the tool tip text (since I had already approved the pull request) but then realized that this is a way to unapprove (undo the approval).
In response, therefore, I recommend replacing the text in this scenario with:
You have approved this pull request (type 'a' to unapprove)
or:
You have approved this pull request (type 'a' to undo the approval)
or some other wording that elucidates that typing 'a' undoes the current state.