Uploaded image for project: 'Bitbucket Data Center'
  1. Bitbucket Data Center
  2. BSERV-7378

"Approve this pull request" text

    XMLWordPrintable

Details

    Description

      While reviewing a pull request, I noticed that when I hover the mouse over the [Approve] button in the upper right corner of the web page, it displays the following tool tip text:

        Approve this pull request (Type 'a')
      

      Nice to have a hot key to approve!

      I would first recommend lowercasing "Type"; as a result, the tool tip text would read as follows:

        Approve this pull request (type 'a')
      

      When I hover the mouse over the [Approve] button after having approved the pull request, the tool tip text now reads as follows:

        You have approved this pull request (Type 'a')
      

      At first, I was going to recommend removing the text "(Type 'a')" from the end of the tool tip text (since I had already approved the pull request) but then realized that this is a way to unapprove (undo the approval).

      In response, therefore, I recommend replacing the text in this scenario with:

        You have approved this pull request (type 'a' to unapprove)
      

      or:

        You have approved this pull request (type 'a' to undo the approval)
      

      or some other wording that elucidates that typing 'a' undoes the current state.

      Attachments

        1. Notification - Approved.png
          Notification - Approved.png
          11 kB
        2. Notification - Unapproved.png
          Notification - Unapproved.png
          11 kB
        3. Proposal - Tooltip - Approved.png
          Proposal - Tooltip - Approved.png
          9 kB
        4. STASH-7378.PNG
          STASH-7378.PNG
          1 kB
        5. Tooltip - Approved.png
          Tooltip - Approved.png
          12 kB
        6. Tooltip - Unapproved.png
          Tooltip - Unapproved.png
          10 kB

        Activity

          People

            dpenkin@atlassian.com Daniil Penkin
            b9ce0f1b55d7 Art Bergquist
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: