A couple times in the past few months I've had pull requests mysteriously approve themselves. I spoke to a co-worker this morning and she clued me in that I must have accidentally typed 'a' while not in focus of a text field.

This is concerning because there was no feedback visible on my screen to let me know I did this. I was too far down the page to see that the Approve button had turned green. Most other keyboard commands give visual feedback when executed, regardless of where you are on the screen.

I think the hotkey should simply be removed. Hotkeys are best for frequent actions. Approving a pull request is nowhere near as frequent and skipping to the next difference.

If you want to keep the hotkey, then I would recommend some sort of confirmation dialog. Yes, it's easy to unapprove a request once you realize you've done it, but this clutters the chat history.

As originally reported here: https://twitter.com/syeberman/status/585820018128093184