Uploaded image for project: 'Bitbucket Data Center'
  1. Bitbucket Data Center
  2. BSERV-7080

Comment/Approve vs Push race

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Medium Medium
    • None
    • 3.5.1
    • Pull Requests
    • None

      If a reviewer opens a pull-request in browser, then comments or approves it, and meanwhile the pull-request is updated, the comment or approve is applied to the new pull-request state without reviewer noticing it.

      Steps:
      1. Developer creates a pull-request
      2. Reviewer opens the pull-request in browser
      3. developer push another commit C to the pull-request.
      4. reviewer comments a change in the pull-request, which is changed in the commits C

      result: the comment fails to bind to a code
      expected: it should be shown in a context with note "Outdated"

      the approve variation, I think it is serious:
      4a. reviewer approves the pull-request

      result: pull-request is approved without reviewing C
      expected: reviewer must look at the updated PR to be able to approve it. PS: In this case, auto-unapproving plugin was installed, it did not help.

            [BSERV-7080] Comment/Approve vs Push race

            Milly Wilson added a comment -

            This is being addressed via BSERV-14141

            Milly Wilson added a comment - This is being addressed via BSERV-14141

              Unassigned Unassigned
              8ad8bd9bec9d Maksim Kirillov
              Affected customers:
              4 This affects my team
              Watchers:
              7 Start watching this issue

                Created:
                Updated:
                Resolved: