Uploaded image for project: 'Bitbucket Data Center'
  1. Bitbucket Data Center
  2. BSERV-5529

As a code reviewer, I'd like to have less pain when reviewing multiple branches from multiple developers who merge one with another

    XMLWordPrintable

Details

    • Suggestion
    • Resolution: Answered
    • None
    • None
    • None
    • We collect Bitbucket feedback from various sources, and we evaluate what we've collected when planning our product roadmap. To understand how this piece of feedback will be reviewed, see our Implementation of New Features Policy.

    Description

      Suppose we have a main branch (develop), and two developers who work on branches feature/A and feature/B.

      Say, developer A needs something that developer B has already created, but it's not yet been merged to the main branch. So developer A merges feature/B into feature/A. Then, maybe developer B needs some changes developer A has made and merges some back.

      When they are finally done, they both create pull requests for merging their feature branches into the main branch. I, developer C, have to review those changes. But what I see when I look at the diff from feature/A to develop is partly changes from developer A, partly changes from developer B.

      So when I need to review these two pull requests, I'll be reviewing some code twice. But that's just a small problem. The big problem is that I don't know who to address a comment to. If I notice a bug, or would like a clarification - in which pull request do I post the comment?

      The problem can be further exacerbated if there are more than 2 developers working in parallel on the interconnected functionality.

      I don't really know a solution, or even if it's a common problem - maybe it doesn't bother other teams. Please let me know if this can be addressed without adding features to Stash. But if it makes sense to address this with some Stash features, I'll double-vote for those.

      Thanks!
      Igor

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              bbf762edcc79 Igor Sereda [ALM Works]
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: