-
Bug
-
Resolution: Fixed
-
Low
-
None
-
None
My colleague did a commit with message:
"...EURUSD SP-3M swap..."
And since this contained a SP-3 Stash said this was a commit for Project SP and issue 3. This shows two different problems:
1. Stash ignored the trailing M from the message and parsed it anyway
2. There are no Project SP in our Jira (so no issue SP-3). Stash shouldn't parse this if no such issue exists
- relates to
-
BSERV-2470 JIRA Integration: Check for issue validity before linking issues
- Closed
-
- Gathering Interest
-
FUSE-1257 Failed to load
- mentioned in
-
Page
Failed to load
[BSERV-4924] Jira issue parsing in Stash commit
You're right, something like that would work for issue keys in commits. For mentioning an issue in a comment, it would have to be handled differently. In any case, these kind of questions are being worked on as the integration evolves. Thanks for the input!
Hi! Thank you for your reply!
By expensive I guess you mean that it would introduce latency issues. Wouldn't it be possible to make an asynchronous request? I guess that Stash still needs to send a message to JIRA that a commit has been pushed to an issue. Wouldn't it be possible for JIRA to answer with a message saying: "Issue A, B and C exists. Issue D doesn't". Until that message is received Stash could act like all issues exists.
If that would be a problem for some users then you could have a setting turning this feature on or off.
Thanks for reporting this!
We changed the issue parser to be more strict for Stash 3.2: It now requires a word boundary at the end of the issue key, so "SP-3M" isn't recognized anymore, while "ABC-123:" still is.
Checking if the issue exists in the connected JIRA instances is more expensive and isn't done at the moment (it would be good to have though).
I've found an existing issue that is about checking if the issue actually exists, see
STASH-2470.