-
Suggestion
-
Resolution: Obsolete
-
None
-
None
I like that the keyboard shortcut "A" can approve a pull request, but I have two issues with it:
- Typing "A" when the pull request header is scrolled off the top of the screen gives no visual indication that the pull request has been approved.
- "A" toggles approval. So if I've already approved the request, typing "A" again removes my approval. If the pull request header is scrolled off the screen I might have forgotten that I've already approved a pull request so typing "A" just removed my approval, again with no visual indication that this was done. I would prefer that "A" not toggle approval, but instead have a separate keyboard shortcut for removing approval such as "shift-A".
- relates to
-
BSERV-9142 Confirm Approval and Unapproval of Pull Requests
- Closed