Uploaded image for project: 'Bitbucket Data Center'
  1. Bitbucket Data Center
  2. BSERV-4462

Allow Pull Request Owner to approve their own Pull Request

XMLWordPrintable

    • Icon: Suggestion Suggestion
    • Resolution: Answered
    • None
    • Pull Requests
    • None
    • We collect Bitbucket feedback from various sources, and we evaluate what we've collected when planning our product roadmap. To understand how this piece of feedback will be reviewed, see our Implementation of New Features Policy.

      The use case I'm imagining is as follows:
      My goal is to have 2 additional people look at my code before merging it. I am accomplishing this by requiring 2 approvals in order to merge a PR.

      1. I create a PR and add Joffrey and Tyrion as reviewers:
      2. Tyrion raises an issue
      3. Joffrey decides to implement the issue himself, and pushes changes to the branch to be merged
      4. Tyrion approves the Pull Request
      5. Joffrey approves the Pull Request and merges

      In this case, only 2 sets of eyes were really reviewing the code (rather than 3, as intended). I would like to configure this repo to require 3 approvals (2 independent and myself), to enforce that there are always at least 2 other people looking at the code, other than the originator - however I can't do this because Stash doesn't allow me to approve my own pull requests. It would be nice to have this option available.

            [BSERV-4462] Allow Pull Request Owner to approve their own Pull Request

            Katherine Yabut made changes -
            Workflow Original: JAC Suggestion Workflow [ 3394295 ] New: JAC Suggestion Workflow 3 [ 3620970 ]
            Status Original: RESOLVED [ 5 ] New: Closed [ 6 ]
            Monique Khairuliana (Inactive) made changes -
            Workflow Original: BSERV Suggestions Workflow [ 2686513 ] New: JAC Suggestion Workflow [ 3394295 ]
            Owen made changes -
            Workflow Original: Stash Workflow [ 627628 ] New: BSERV Suggestions Workflow [ 2686513 ]
            Status Original: Closed [ 6 ] New: Resolved [ 5 ]
            Michael McGlynn (Inactive) made changes -
            Summary Original: Allow Pull Request Owner to approve his own Pull Request New: Allow Pull Request Owner to approve their own Pull Request
            Bryan Turner (Inactive) made changes -
            Link New: This issue is duplicated by BSERV-9544 [ BSERV-9544 ]
            Justus Pendleton (Inactive) made changes -
            Issue Type Original: New Feature [ 2 ] New: Suggestion [ 10000 ]
            Priority Original: Minor [ 4 ]
            Roger Barnes (Inactive) made changes -
            Resolution New: Answered [ 9 ]
            Status Original: Needs Triage [ 10030 ] New: Closed [ 6 ]
            Mike Kessler created issue -

              Unassigned Unassigned
              3559c63d209e Mike Kessler
              Votes:
              0 Vote for this issue
              Watchers:
              15 Start watching this issue

                Created:
                Updated:
                Resolved: