Uploaded image for project: 'Bitbucket Server'
  1. Bitbucket Server
  2. BSERV-4462

Allow Pull Request Owner to approve their own Pull Request

    XMLWordPrintable

    Details

    • Type: Suggestion
    • Status: Resolved (View Workflow)
    • Resolution: Answered
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Pull Requests
    • Labels:
      None
    • Feedback Policy:
      We collect Bitbucket feedback from various sources, and we evaluate what we've collected when planning our product roadmap. To understand how this piece of feedback will be reviewed, see An updated workflow for server feature suggestions.

      Description

      The use case I'm imagining is as follows:
      My goal is to have 2 additional people look at my code before merging it. I am accomplishing this by requiring 2 approvals in order to merge a PR.

      1. I create a PR and add Joffrey and Tyrion as reviewers:
      2. Tyrion raises an issue
      3. Joffrey decides to implement the issue himself, and pushes changes to the branch to be merged
      4. Tyrion approves the Pull Request
      5. Joffrey approves the Pull Request and merges

      In this case, only 2 sets of eyes were really reviewing the code (rather than 3, as intended). I would like to configure this repo to require 3 approvals (2 independent and myself), to enforce that there are always at least 2 other people looking at the code, other than the originator - however I can't do this because Stash doesn't allow me to approve my own pull requests. It would be nice to have this option available.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                kessler Mike Kessler
              • Votes:
                0 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: