• Icon: Suggestion Suggestion
    • Resolution: Fixed
    • 3.2.0
    • Usability
    • None
    • We collect Bitbucket feedback from various sources, and we evaluate what we've collected when planning our product roadmap. To understand how this piece of feedback will be reviewed, see our Implementation of New Features Policy.

      Lets say I have a pull request out for review. People comment on it.

      I seriously need "next comment" / "previous comment" to be able to (as the original commiter) follow the feedback and in context of the diff.

      Pretty much like FishEye does with its next comment functionality.

          Form Name

            [BSERV-3620] Previous and next comment keyboard shortcuts

            Poods1963 added a comment -

            Keyboard shortcuts help us a lot to save time. You can get a top essay writing service to learn more ways of study. Through these shortcuts, we can make our greater work done in no time. I have learned a lot of shortcut keys from this blog and these are helping me in my professional and daily tasks to be done efficiently.

            Poods1963 added a comment - Keyboard shortcuts help us a lot to save time. You can get a  top essay writing service  to learn more ways of study. Through these shortcuts, we can make our greater work done in no time. I have learned a lot of shortcut keys from this blog and these are helping me in my professional and daily tasks to be done efficiently.

            +1 for the keyboard navigation — would be useful on the overview page also.

            Igor Baltiyskiy added a comment - +1 for the keyboard navigation — would be useful on the overview page also.

            bbaker you can click on the tear at the bottom of that diff to expand the context. You can also click through to the diff by using the view diff link in the top right the diff in the overview to take you do the full diff.

            jhinch (Atlassian) added a comment - bbaker you can click on the tear at the bottom of that diff to expand the context. You can also click through to the diff by using the view diff link in the top right the diff in the overview to take you do the full diff.

            Here is an example

            Ed made this comment about another valueorder field.

            The email led me to the overview screen

            But the code is not here? Its just out of reach.

            If I was on the diff view I could see that code

            If I had n/p then I could navigate to comments within that context

            ɹǝʞɐq pɐɹq added a comment - Here is an example Ed made this comment about another valueorder field. The email led me to the overview screen But the code is not here? Its just out of reach. If I was on the diff view I could see that code If I had n/p then I could navigate to comments within that context

            Being on the diff page allows ME to choose the amount of context. IN this case ALL of it.

            I am not particularly interested in a "activity streams" like interface of the review. I work in terms of the code not Stash

            I want to be able to review the code and the comments at the same time and navigate easily between them.

            ɹǝʞɐq pɐɹq added a comment - Being on the diff page allows ME to choose the amount of context. IN this case ALL of it. I am not particularly interested in a "activity streams" like interface of the review. I work in terms of the code not Stash I want to be able to review the code and the comments at the same time and navigate easily between them.

            I want to as the author review those comments in series so I can act and absorb the code review feedback.

            You have described the overview tab. If you start at the bottom and work your way up you are addressing the comments in series in the order they were made.

            I'm not disregarding the usefulness of keyboard navigation. This is definitely something we can look into improving. I'm just trying to better understand what you are trying to achieve and why the current tabs aren't sufficient.

            I dont find the overview page that useful. I want the code as context to the comments and not just some lines in and around a comment.

            Is it that you want to jump around multiple files before addressing a comment? If this is the case then 'being more like Crucible' would not solve this problem. If its just that you want more lines of context you can do that by expanding the lines of context in the overview tab (by clicking on the squiggly line at the edge of the diff).

            jhinch (Atlassian) added a comment - I want to as the author review those comments in series so I can act and absorb the code review feedback. You have described the overview tab. If you start at the bottom and work your way up you are addressing the comments in series in the order they were made. I'm not disregarding the usefulness of keyboard navigation. This is definitely something we can look into improving. I'm just trying to better understand what you are trying to achieve and why the current tabs aren't sufficient. I dont find the overview page that useful. I want the code as context to the comments and not just some lines in and around a comment. Is it that you want to jump around multiple files before addressing a comment? If this is the case then 'being more like Crucible' would not solve this problem. If its just that you want more lines of context you can do that by expanding the lines of context in the overview tab (by clicking on the squiggly line at the edge of the diff).

            I will tell you its more about flow as a code review.

            I get an email about a code review I have started. People are commenting and so on.

            I want to as the author review those comments in series so I can act and absorb the code review feedback.

            This strikes me as one of those "be more like FishEye" features for a better code review experience.

            Maybe if I am on the overview page then n / p should go to each comment in that context but if I am in the diff view it should stay in that context and traverse comments.

            As I have said in personal conversations with you guys, I dont find the overview page that useful. I want the code as context to the comments and not just some lines in and around a comment.

            ɹǝʞɐq pɐɹq added a comment - I will tell you its more about flow as a code review. I get an email about a code review I have started. People are commenting and so on. I want to as the author review those comments in series so I can act and absorb the code review feedback. This strikes me as one of those "be more like FishEye" features for a better code review experience. Maybe if I am on the overview page then n / p should go to each comment in that context but if I am in the diff view it should stay in that context and traverse comments. As I have said in personal conversations with you guys, I dont find the overview page that useful. I want the code as context to the comments and not just some lines in and around a comment.

              Unassigned Unassigned
              bbaker ɹǝʞɐq pɐɹq
              Votes:
              3 Vote for this issue
              Watchers:
              10 Start watching this issue

                Created:
                Updated:
                Resolved: