Loading...

XML

Word

Printable

Details

Type: Bug
Resolution: Unresolved
Priority: Medium
Fix Version/s: None
Affects Version/s: 2.1.2
Component/s: Pull Request - Comments
Labels:
- pull-request

Support reference count:
2
Symptom Severity:
Severity 2 - Major
UIS:
4
Bug Fix Policy:
View Atlassian Server bug fix policy

Description

If someone comment Pull Request and someone else push commit to it, then Stash create comment on old lines for old code, but attach it to new code. In result you will see comment attached to wrong lines and it will make crazy someone who start to read comments on diff. Diff is from new commited code, but comment from old commit atached to old commit lines.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List

Screen Shot 2013-03-04 at 23.22.56.png
57 kB
04/Mar/2013 7:29 PM
Screen Shot 2013-03-04 at 23.24.38.png
39 kB
04/Mar/2013 7:29 PM

Issue Links

causes

BSERV-12799 Pull request diff suggestions are incorrectly shown if the code is changed by a commit to the same file before the suggestion is saved by the user

Gathering Impact

BSERV-9339 Please fix or remove the "Review pull requests at the commit level" feature

Closed

is duplicated by

BSERV-4479 Anchor pull request comments to content to which they relate, not to a fixed line number

Closed

BSERV-11464 Comment ends up on unintended line.

Closed

is incorporated by

BSERV-7080 Comment/Approve vs Push race

Closed

mentioned in: Page Loading...; Page Loading...; Page Loading...; Page Loading...; Page Loading...

(5 mentioned in)

Activity

People

Assignee:: Unassigned

Reporter:: Alexey Efimov

Votes:: 4 Vote for this issue

Watchers:: 11 Start watching this issue

Dates

Created:: 04/Mar/2013 7:21 PM

Updated:: 05/Apr/2024 3:06 AM

Concurrent commits force Stash to create wrong comments in Pull Requests

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Backbone Issue Sync