• We collect Bitbucket feedback from various sources, and we evaluate what we've collected when planning our product roadmap. To understand how this piece of feedback will be reviewed, see our Implementation of New Features Policy.

      Atlassian status as of January 2017

      Hi everyone,

      We are pleased to share that in-browser editing for existing files is now available in Bitbucket Server 4.13. This new capability respects all existing permissions, and provides the option to commit directly or create a pull request, as appropriate.

      For more details, please see the blog and release notes. Please also see BSERV-8269 for updates where we're tracking further possible improvements to allow adding, renaming and deleting files from the web UI.

      As always, thanks to everyone for your input with votes and comments, and your patience as we try to make Bitbucket Server do all the things that help you, and your teams, make the software you create amazing.

      Cheers,
      Roger Barnes

      Product Manager - Bitbucket Server

      Original request description

      It would be nice to have in-line file editing, and then the person who edits the files in the Stash UI can send a Pull Request, like GitHub does. This would also be nice to implement into Bitbucket as well.

            [BSERV-3032] In-line File Editing

            Agreed with Dave Thomas, documentation shall add a little section about "automatic" pre-receive hook bypassing with new FileEditor feature as i believe a lot of companies implemented such verify hooks.

            A good thing that it can be disabled via features.file.editor property

            Samy Lerari added a comment - Agreed with Dave Thomas, documentation shall add a little section about "automatic" pre-receive hook bypassing with new FileEditor feature as i believe a lot of companies implemented such verify hooks. A good thing that it can be disabled via features.file.editor property

            Thanks for the helpful information on this, Roger. It looks like we'll need to disable this at my company until BSERV-9521 is implemented. In the meantime, I think the documentation needs to be updated to let people know that this feature allows users to bypass existing hooks.

            Dave Thomas added a comment - Thanks for the helpful information on this, Roger. It looks like we'll need to disable this at my company until BSERV-9521 is implemented. In the meantime, I think the documentation needs to be updated to let people know that this feature allows users to bypass existing hooks.

            Push / merge hooks are extremely important to enforcing our workflow, and I suspect the same is true for almost every Bitbucket instance with more than a few users. This feature is half-baked if it does not respect the existing hooks – are there even any hook plugins that filter FileEditRequestedEvent?

            John Jacobson added a comment - Push / merge hooks are extremely important to enforcing our workflow, and I suspect the same is true for almost every Bitbucket instance with more than a few users. This feature is half-baked if it does not respect the existing hooks – are there even any hook plugins that filter FileEditRequestedEvent?

            dave.thomas318283010, there is a FileEditRequestedEvent that can theoretically be used for this, but it lacks some of the equivalent information available to hooks. There's a new improvement suggestion for that at BSERV-9521. In the meantime, if you need to turn off the edit feature it can be done instance wide with a config property.

            mohammeddavoodi, just a heads up that while we didn't get add, rename and delete support into this release, it is a possibility for future. In general, we recommend add-on vendors contact us if there's a popular suggestion that they are considering developing an add-on for, unless it's already labelled "plugin_opportunity".

            Patrick.Chen1110161846, there is no upload button currently as the feature we shipped allows for editing existing files only via the UI. The REST API does let you add files using the same API however, in case that's useful. See BSERV-8269 to track updates for the UI.

            Roger Barnes (Inactive) added a comment - dave.thomas318283010 , there is a FileEditRequestedEvent that can theoretically be used for this, but it lacks some of the equivalent information available to hooks. There's a new improvement suggestion for that at BSERV-9521 . In the meantime, if you need to turn off the edit feature it can be done instance wide with a config property . mohammeddavoodi , just a heads up that while we didn't get add, rename and delete support into this release, it is a possibility for future. In general, we recommend add-on vendors contact us if there's a popular suggestion that they are considering developing an add-on for, unless it's already labelled "plugin_opportunity". Patrick.Chen1110161846 , there is no upload button currently as the feature we shipped allows for editing existing files only via the UI. The REST API does let you add files using the same API however, in case that's useful. See BSERV-8269 to track updates for the UI.

            patrick.chen1110161846 added a comment -

            how do you even enable file editing. i dont see the edit button at all. i'm an admin of the repo. i want to upload a file, but don't see any file upload button. 

            patrick.chen1110161846 added a comment - how do you even enable file editing. i dont see the edit button at all. i'm an admin of the repo. i want to upload a file, but don't see any file upload button. 

            Hey Dave, look at BSERV-8985. Currently the built-in Editor does not have support for checking with hooks. Our plugin [Editor for Bitbucket |https://marketplace.atlassian.com/plugins/com.mohamicorp.stash.plugin.editor-for-stash/server/overview,] does support pre and post commit hooks as well as adding files. We'll support removing and renaming files in a few more days.

            Mohammed Davoodi added a comment - Hey Dave, look at  BSERV-8985 . Currently the built-in Editor does not have support for checking with hooks. Our plugin [Editor for Bitbucket | https://marketplace.atlassian.com/plugins/com.mohamicorp.stash.plugin.editor-for-stash/server/overview ,] does support pre and post commit hooks as well as adding files. We'll support removing and renaming files in a few more days.

            Great news, but.... we perform a lot of checks using hooks that are fired when commits are being pushed. For example, we check the commit message for a valid Jira issue ID. I looked at the release notes, but I don't see any mention of which hooks would be fired (if any) when commits are made via the web UI like this. Can someone from Atlassian please elaborate?

            Dave Thomas added a comment - Great news, but.... we perform a lot of checks using hooks that are fired when commits are being pushed. For example, we check the commit message for a valid Jira issue ID. I looked at the release notes, but I don't see any mention of which hooks would be fired (if any) when commits are made via the web UI like this. Can someone from Atlassian please elaborate?

            We are pleased to share that in-browser editing for existing files is now available in Bitbucket Server 4.13. This new capability respects all existing permissions, and provides the option to commit directly or create a pull request, as appropriate.

            For more details, please see the blog and release notes. Please also see BSERV-8269 for updates where we're tracking further possible improvements to allow adding, renaming and deleting files from the web UI.

            As always, thanks to everyone for your input with votes and comments, and your patience as we try to make Bitbucket Server do all the things that help you, and your teams, make the software you create amazing.

            Roger Barnes (Inactive) added a comment - We are pleased to share that in-browser editing for existing files is now available in Bitbucket Server 4.13. This new capability respects all existing permissions, and provides the option to commit directly or create a pull request, as appropriate. For more details, please see the blog and release notes . Please also see BSERV-8269 for updates where we're tracking further possible improvements to allow adding, renaming and deleting files from the web UI. As always, thanks to everyone for your input with votes and comments, and your patience as we try to make Bitbucket Server do all the things that help you, and your teams, make the software you create amazing.

            Just to point out, the plugin mentioned above (https://marketplace.atlassian.com/plugins/com.mohamicorp.stash.plugin.editor-for-stash) has a really sweet feature – once can edit pull requests, so it's possible to iterate on a pull request purely in the browser. Super handy for small nitpicks when a pull request is almost ready.

            John Jacobson added a comment - Just to point out, the plugin mentioned above ( https://marketplace.atlassian.com/plugins/com.mohamicorp.stash.plugin.editor-for-stash ) has a really sweet feature – once can edit pull requests, so it's possible to iterate on a pull request purely in the browser. Super handy for small nitpicks when a pull request is almost ready.

            Ingo Mohr added a comment -

            This really should be an out-of-the-box feature in BBS. This lack of this feature grows to be a number-1 reason to avoid BBS and use Github or other tools instead.

            Ingo Mohr added a comment - This really should be an out-of-the-box feature in BBS. This lack of this feature grows to be a number-1 reason to avoid BBS and use Github or other tools instead.

              Unassigned Unassigned
              454b27d701d7 Evelyn
              Votes:
              123 Vote for this issue
              Watchers:
              67 Start watching this issue

                Created:
                Updated:
                Resolved: