Uploaded image for project: 'Bitbucket Data Center'
  1. Bitbucket Data Center
  2. BSERV-2927

Review and comment on pull request diffs, broken down first by commit.

    XMLWordPrintable

Details

    • Suggestion
    • Resolution: Duplicate
    • None
    • Pull Requests
    • None
    • We collect Bitbucket feedback from various sources, and we evaluate what we've collected when planning our product roadmap. To understand how this piece of feedback will be reviewed, see our Implementation of New Features Policy.

    Description

      We would like an option to comment on diffs in a pull request, but viewable first broken down by commit.

      All of the pieces are effectively already there, because the pull request UI has a tab called 'Commits' which lets you see the commits that form the pull request. These commits have links:

      However, when you click on a link, it takes you to a 'Commits' tab at a level in parallel with 'Pull requests':

      ... and you can't make comments at this point.

      We want to be able to comment on the individual change sets within a pull request, not just the pull request as a whole.

      The reason is this:

      A complex pull request can have changed a lot of files. However, the individual commits within a pull request will (hopefully) have broken the changes into more intellectual digestible chunks. By viewing the pull request as a series of commits, the reviewer gets to go on the same logical journal as the original author took (or, that the original author synthesised through rebasing prior to pushing).

      Attachments

        1. commits_tab.png
          commits_tab.png
          18 kB
        2. see_commits.png
          see_commits.png
          34 kB

        Issue Links

          Activity

            People

              Unassigned Unassigned
              be77804935b2 Greg Kopff
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: