Improve access token expiry policy caching

XMLWordPrintable

    • 34
    • 10

      Feature request: Improve access token expiry policy caching

      When no global token expiry policy is configured, Bitbucket repeatedly queries the database for the missing setting because this lookup does not cache absent values.

      The setting lookup also runs in a separate transaction. A token operation thread can retain one database connection while waiting for another, contributing to pool exhaustion under high concurrency, e.g. when there's a spike in calls that use access tokens.

      In observed incidents, application logs show DB pool exhaustion:

      2026-10-21 00:19:17,133 WARN  [http-nio-7990-exec-86] *FA86FMx19x577367x32 [IP_1] "GET /rest/api/latest/projects/PROJ_KEY/repos/repo_slug/raw/some/path HTTP/1.1" c.a.s.i.jdbc.ConnectionTracker The database pool is exhausted. Stacks for the threads holding connections follow:
      

      Multiple threads holding on to connections show they're waiting for another connection while reading the global expiry policy during token authentication.

      Sample:

      2026-10-21 00:19:17,134 WARN  [http-nio-7990-exec-86] *FA86FMx19x577367x32 [IP_1] "GET /rest/api/latest/projects/[PROJECT_1]/repos/[REPO_1]/raw/some/path HTTP/1.1" c.a.s.i.jdbc.ConnectionTracker Stack trace for http-nio-7990-exec-180
      com.atlassian.stash.internal.util.StackException: Stack trace for http-nio-7990-exec-180
          at java.base/jdk.internal.misc.Unsafe.park(Native Method)
          ...
          at com.zaxxer.hikari.util.ConcurrentBag.borrow(ConcurrentBag.java:151)
          at com.zaxxer.hikari.pool.HikariPool.getConnection(HikariPool.java:180)
          ...
          at org.springframework.jdbc.datasource.LazyConnectionDataSourceProxy$LazyConnectionInvocationHandler.getTargetConnection(LazyConnectionDataSourceProxy.java:405)
          ...
          at org.hibernate.persister.entity.AbstractEntityPersister.loadByNaturalId(AbstractEntityPersister.java:2494)
          ...
          at com.atlassian.stash.internal.plugin.HibernatePluginSettingDao.getByKey(HibernatePluginSettingDao.java:102)
          at com.atlassian.stash.internal.plugin.HibernatePluginSettingDao.get(HibernatePluginSettingDao.java:79)
          ...
          at com.atlassian.stash.internal.plugin.DefaultPluginSettings.lambda$getActual$0(DefaultPluginSettings.java:41)
          at org.springframework.transaction.support.TransactionTemplate.execute(TransactionTemplate.java:140)
          at com.atlassian.stash.internal.plugin.DefaultPluginSettings.getActual(DefaultPluginSettings.java:41)
          ...
          at com.atlassian.bitbucket.internal.accesstokens.DefaultAccessTokenSettingsService.getMaxExpiryDaysInternal(DefaultAccessTokenSettingsService.java:101)
          at com.atlassian.bitbucket.internal.accesstokens.DefaultAccessTokenSettingsService.getMaxExpiry(DefaultAccessTokenSettingsService.java:58)
          at com.atlassian.bitbucket.internal.accesstokens.auth.DefaultAccessTokenAuthenticationService.lambda$authenticate$2(DefaultAccessTokenAuthenticationService.java:104)
          ...
          at com.atlassian.stash.internal.sal.spi.HostContextAccessorImpl.doInTransaction(HostContextAccessorImpl.java:54)
          ...
          at com.atlassian.sal.core.transaction.HostContextTransactionTemplate.execute(HostContextTransactionTemplate.java:18)
          ...
          at com.atlassian.bitbucket.internal.accesstokens.auth.DefaultAccessTokenAuthenticationService.authenticate(DefaultAccessTokenAuthenticationService.java:80)
      

              Assignee:
              Ben Humphreys
              Reporter:
              JP Mariano
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: