Configuration for editable hooks not visible when repository changes are disabled

XMLWordPrintable

    • 1
    • Severity 2 - Major

      Issue Summary

      This is reproducible on Data Center: yes

      Replication steps below use the bundled Minimum Approvers merge check, but any configurable hook or merge check present on either of these pages will be affected.

      Steps to Reproduce

      1. Navigate to the merge checks tab of a project
      2. Enable the "Minimum Approvers" merge check. When enabling, enter any value in the config modal for "Number of approvals"
      3. Set repository changes to "Don't allow" on the same merge check
      4. Edit the configuration

      Expected Results

      The modal appears and displays the value entered previously

      Actual Results

      The configuration modal is empty, and the value will not be displayed. 

      Two things to note with this issue:

      • A user can enter a new value into this modal and it will be persisted; the issue is with fetching the persisted value in the UI
      • The merge check or hook will still use this configuration; e.g. with minimum approvers above, the merge check is still enforced with the number of approvers entered.

      Workaround

      Currently there is no known workaround for this behavior. A workaround will be added here when available

            Assignee:
            Unassigned
            Reporter:
            Martin Henschke
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: