Ability to render all files in diff view (more than MAX_LIMIT) for large PR

XMLWordPrintable

    • CtB - Improve Existing

      In a large Pull request with diff in more than 1000 files, a message is shown

       

      While this is helpful so that browser doesn't slow down but it has issues in scenarios:

      • When a comment exists (added via rest) to a file which is after the max limit, it cannot be opened in diff view
      • Search or Filter is also affected

       

      This max limit is from changes endpoint.

      Possible options to improve it

      • Pagination for changes endpoint
      • Instead of files, changed dirs are returned, which can then be expanded for the changed files within (no paging). - There is "Get files in a directory"
      • If the commentId in the URL param is not fetched by the first 1000 files; the single specific comment and anchored file could be fetched
      • The search filters/sorting is applied to the fetch call, not the post-processing on screen.

            Assignee:
            Unassigned
            Reporter:
            Navpreet Ahuja
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: