Create pull request: Current state is not defined

XMLWordPrintable

    • Severity 3 - Minor
    • CtB - Improve Existing

      Issue Summary

      The current state of the Files/Folders is not defined programmatically.

      Steps to Reproduce

      1. Open the "Create pull request" page.
      2. Navigate to the “Files/Folders” present in the Diff tab.
      3. Inspect the code for the mentioned instances.
      4. Notice that the current state is not programmatically defined.

      Screenshot

      Actual Results

      The current state is not programmatically defined for the Files/Folders such as “aio“, "docs", "Integration" and so on in the Diff tab in the main content area.

      As a result, screen reader users will not be aware of the currently active state of the file/folder link that has been opened.

      Expected Results

      The screen reader should announce the current state of the file/folder that is active while navigating through the “Diff tab“ that is present.

      Ensure that the current state of the active link is defined using the "aria-current" attribute with an appropriate token value.

      Apply the following changes:

      • Add the aria-current="true" attribute to the <a> element of the File/Folder.
      • Ensure that the "aria-current" attribute is updated as per user interaction using scripting.

      Code Example:

      <a href="#.pullapprove.yml" aria-label=".pullapprove.yml has been modified" title=".pullapprove.yml has been modified">...</a>
      ...
      <a aria-current-"true" href="#.travis.yml" aria-label=".travis.yml has been modified" title=".travis.yml has been modified">...</a>
      ...
      <a href="#BUILD.bazel" aria-label="BUILD.bazel has been modified" title="BUILD.bazel has been modified">...</a>
      ...

      Workaround

      Currently, there is no known workaround for this behaviour. A workaround will be added here when available

      Environment

      MacBook Pro (16-inch, 2021)
      macOs Sonoma 14.3
      Chrome - Version 120.0.6099.109 (Official Build) (arm64)
      Firefox- Version 92.0 (64-bit) 
      Safari- Version 17.3 (19617.2.4.11.8)
      JAWS- Version 2023
      NVDA- Version 2021.2 
      Voiceover - Version Latest

            Assignee:
            Matthew Hanselman
            Reporter:
            Rahul Patil (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: