View pull request: Pressed elements are not programmatically identified

XMLWordPrintable

    Issue Summary

     On the “View pull request” page, the button does not have a programmatically defined pressed state.

    Steps to Reproduce

    1. Navigate to the “View pull request”page.
    2. Navigate to the mentioned instances.
    3. Observe that the button is visually pressed.
    4. Inspect the code of the mentioned instances.
    5. Observe that the pressed state is not programmatically determined.

    Screenshot

    Actual Results

    The visually pressed button "Mark as read" does not have a programmatically defined pressed state. This might disorient the users of assistive technologies, and the pressed state is not programmatically determined may confuse or mislead them.

    Expected Results

    When an element is visually pressed, make sure that this information is indicated programmatically as well. Use “aria-pressed” attribute on the button and update the “true” and “false” values appropriately. The value should be set to “true” when the button is pressed and “false” when the button is not pressed.

    Workaround

    Currently, there is no known workaround for this behaviour. A workaround will be added here when available.

    Environment

    MacBook Pro (16-inch, 2019)
    macOs Ventura 13.5.1
    Chrome - Version 113.0.5672.63 (Official Build) (x86_64)
    Firefox- Version 92.0 (64-bit)
    Safari- Version 16.4 (18615.1.26.110.1)
    JAWS- Version 2022
    NVDA- Version 2021.2
    Voiceover - Version Latest

            Assignee:
            Carlos Sanchez Rosa
            Reporter:
            Nayan Kamble (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: