Create Pull Request: Missing list mark-up for buttons

XMLWordPrintable

    Issue Summary

    The buttons such as "Bold", "Italic", "Strikethrough" and so on are not marked in the list mark-up.

    Note: A similar issue is observed on multiple tab on the "View Pull Request" page.

    Steps to Reproduce

    1. Navigate to the mentioned page.
    2. Navigate to the "Continue"  button and activate it 
    3. Using a screen reader, navigate to the mentioned buttons.
    4. Listen that the list structure is not announced for the buttons that represent related information.

    Screenshot 1

    Screenshot 2

    Actual Results

    The buttons such as "Bold", "Italic", "Strikethrough" and so on are not marked as an unordered list which visually looks like a list of related items. As a result, screen reader users will find it difficult to navigate to the list and different list items quickly.

    Expected Results

    Use appropriate list mark-up, such as <ul> and <li> to identify related information. In addition, consider applying styles to maintain the visual presentation of a web page.

    <ul>
    <li role="presentation">
    <button aria-describedby="editor-formatting-button-tooltip" class="css-nuertc" type="button" tabindex="0">
    <span class="css-1ujqpe8">
    <span role="img" aria-label="Bold" class="css-pxzk9z" style="--icon-primary-color: currentColor; --icon-secondary-color: var(--ds-surface, #FFFFFF);">
    (...)
    </span></span></button>
    </li>
    <li role="presentation">
    <button aria-describedby="editor-formatting-button-tooltip" class="css-nuertc" type="button" tabindex="0">
    <span class="css-1ujqpe8">
    <span role="img" aria-label="Italic" class="css-pxzk9z" style="--icon-primary-color: currentColor; --icon-secondary-color: var(--ds-surface, #FFFFFF);">
    (...)
    </span></span></button>
    </li>
    (...)
    </ul>

    Workaround

    Not available

    Environment 

    MacBook Pro (16-inch, 2019)
    macOS 13.4.1 (c) (22F770820d)
    Chrome - Version 115.0.5790.170 (Official Build) (x86_64)
    Firefox- Version 114.0 (64-bit)
    Safari- Version 16.5.2 (18615.2.9.11.10)
    JAWS- Version 2023.2306.28
    NVDA- Version 2022.2.2
    Voiceover - Version Latest

            Assignee:
            Carlos Sanchez Rosa
            Reporter:
            Rahil Shaikh
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: