SecretScanningWiring raises unnecessary warning on startup

XMLWordPrintable

    • Severity 3 - Minor

      Issue Summary

      This is reproducible on Data Center: yes

      SecretScanningWiring raises unnecessary warning on startup. It complains about an invalid value for secretscanning.email.maxsecrets even if it was not set by the user.

      Steps to Reproduce

      1. Start Bitbucket
      2. Inspect the atlassian-bitbucket.log

      Expected Results

      No warning is logged if the user has not set (or specifically incorrectly set) the maxsecrets property themself.

      Actual Results

      The below warning is logged in atlassian-bitbucket.log:

      2023-07-07 16:09:24,647 WARN  [spring-startup]  c.a.s.i.s.SecretScanningWiring Invalid value for 'secretscanning.email.maxsecrets': secretscanning.email.maxsecrets is not a positive integer. Using default value of 100 instead.

      Workaround

      Setting secretscanning.email.maxsecrets': secretscanning.email.maxsecrets to (for example) 100 in bitbucket.properties will suppress the warning

            Assignee:
            Brent P
            Reporter:
            Ben Humphreys
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: