Details
-
Bug
-
Resolution: Fixed
-
Low
-
4.14.0
-
None
-
Severity 3 - Minor
-
Description
Summary
Cannot edit a default reviewer from the repository settings if one of the reviewers is inactive or deleted
Steps to reproduce:
- Create a default reviewer rule that contains userA as a reviewer
- Delete userA
- Edit the default reviewer rule
- Get a 500 'server error' page
2017-09-13 00:06:57,312 ERROR [http-nio-9080-exec-78] {username} *SXHHI5x6x115955x8 1at19g 172.22.36.161,10.64.50.15,10.124.187.106 "PUT /rest/default-reviewers/latest/projects/{projectkey}/repos/{reposlug}/condition/106 HTTP/1.1" c.a.s.i.r.e.DefaultUnhandledExceptionMapperHelper Unhandled exception while processing REST request: "PUT /rest/default-reviewers/latest/projects/{projectkey}/repos/{reposlug}/condition/106 HTTP/1.1"
java.lang.NullPointerException: null
at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
at java.util.HashMap$KeySpliterator.forEachRemaining(HashMap.java:1548)
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)
at com.atlassian.bitbucket.internal.defaultreviewers.DefaultPullRequestConditionService.updatePullRequestCondition(DefaultPullRequestConditionService.java:201)
at com.atlassian.bitbucket.internal.defaultreviewers.DefaultAutoReviewersService.updatePullRequestCondition(DefaultAutoReviewersService.java:93)
at com.atlassian.bitbucket.internal.defaultreviewers.rest.DefaultReviewersResourceHelper.updatePullRequestCondition(DefaultReviewersResourceHelper.java:73)
at com.atlassian.bitbucket.internal.defaultreviewers.rest.DefaultReviewersRepositoryResource.updatePullRequestCondition(DefaultReviewersRepositoryResource.java:163)
Expected Results
Update the default reviewers settings with new users
Workaround
Remove the deleted user from the default reviewers list and then add the new users