Uploaded image for project: 'Bitbucket Data Center'
  1. Bitbucket Data Center
  2. BSERV-10459

Pull Request Comments Were Missed

    XMLWordPrintable

Details

    • Suggestion
    • Resolution: Duplicate
    • None
    • None
    • None
    • We collect Bitbucket feedback from various sources, and we evaluate what we've collected when planning our product roadmap. To understand how this piece of feedback will be reviewed, see our Implementation of New Features Policy.

    Description

      We are missing bugs that reviewers reported in BitBucket Pull Requests – due to a nuance of this tool. We like this tool! But please help us catch all of the bugs we report.

      PROBLEM DESCRIPTION:

      Pull Requests (PR) are starting to feel too complicated to be thorough, when we have a lot of comments on multiple files and multiple commits.  We need a way to know we've addressed all comments, but the way Bitbucket displays them sometimes makes them hard to see.  For instance, during a Pull Request, our natural inclination is to review a file from top to bottom. The Overview page is listed in reverse chronological order of when comments were made, which would be inconvenient for a comprehensive code review with multiple files and reviewers. So instead of using the overview page, we go straight to the Diff page, and select the files to review in order, using "Show Diff of 'All changes in this pull request'".

      Unfortunately, I just learned that that setting does NOT show all the review comments if there are multiple commits. If some comments are made in a BitBucket Pull Request, then the author uploads corrections for those comments, and then additional comments are made: not all the comments will be displayed. If we don't realize the problem (which has happened), we may never review all the comments. Our expectation was that I would see them all, so the interface was not intuitive enough to help us get it right.  We need to go through the Overview page to make sure all were covered.  But with a hundred comments, all colored the same, in order of comment creation – it is tedious and error-prone to search.

      POSSIBLE SOLUTIONS:

      All the comments are on the Overview page, but that page is not in an efficient format for large reviews. If it had the ability to change its sort order to "By File" in addition to the default "Reverse Chronological", we could more easily find the missing information.

      Similarly, maybe a checkbox on the Overview page could enable comment display for each commit, so they could be cycled through.

      Another option would be to have a Diff view that somehow marked how many unique comments exist on each commit, similar to the red circle with a white number currently employed in the top-right of my screen, that indicates the number of unapproved Pull Requests I have that are outstanding.

      Another option may be to allow comments to be marked as read or resolved, and then display a "number of comments not read by reviewers" count so we can make sure it is zero before approving a PR.

      Another option would be to allow a Diff View to accumulate changes and comments from multiple commits. That sounds technically challenging, though it would be nice.

      Another option may be to carry forward comments with each new commit, until they are marked resolved. That would be neat, but seems technically challenging.

      Thank you for considering this problem.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              68b0f788e5c8 Hopeful
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: