Apologies for the late update. The change to ignore the ref prefix when applying the length limit was included in the 5.16.1 patch release (and subsequent 5.16 patch releases, of course), and the 6.0.0 major release.

Best regards,
Bryan Turner
Atlassian Bitbucket

Stefan,

There will never be a 5.17 release. The next release will be 6.0.0. However, there will be future 5.16.x point releases, which will make this fix available without requiring a major version upgrade.

Best regards,
Bryan Turner
Atlassian Bitbucket

Yes, better solution! Thanks for fast reaction.

stefan.felkel

Thanks for the suggestion! I've decided to go a different way, though. Forcing end users to be aware of the extra /refs/heads/ and refs/tags/ qualifiers when creating refs produces a confusing user experience no matter how we try to message it. Rather than push that knowledge all the way through, the system now (effectively) ignores the Git qualifiers when enforcing the length limit. The branch model prefix, if any, is still considered, and the combination of both things can't exceed 100 characters, but if the branch name + refs/heads/ is over 100 characters it's no longer an error.

The change is up for review internally, now. Once it's merged, I'm targeting the next 5.16 point release for the fix.

Best regards,
Bryan Turner
Atlassian Bitbucket

Suggestion for the fix (please review):

(Source Bitbucket 5.16.0)  BranchCreationData.java (105)

FROM
 

[...]
int maxBranchLength = ISSUE_BRANCH_NAME_LIMIT - prefixLength;
[...]

TO
 

[...]
prefixLength += 1;    // if "/" is not already part of prefixLength
int maxBranchLength = ISSUE_BRANCH_NAME_LIMIT - prefixLength - "refs/heads/".length();
[...]

Debugged code by an example:

ISSUE_BRANCH_NAME_LIMIT = 100

Summary = "BIB-3781-_bib1837_-hunkchoice-stringkoord-throws-exception-if-lwert-is-out-of-bounds"   (84)
Prefix = "bugfix" (6)

Prefix + "/" + Summary = "bugfix/BIB-3781-_bib1837_-hunkchoice-stringkoord-throws-exception-if-lwert-is-out-of-bounds" (91)

gitPrefix = "refs/heads" (10)

gitPrefix + "/" Prefix + "/" + Summary = "refs/heads/bugfix/BIB-3781-_bib1837_-hunkchoice-stringkoord-throws-exception-if-lwert-is-out-of-bounds" (102)

Error message produced here:

(Source Bitbucket 5.16.0)  DefaultGitRefCommandFactory.java (225)

if (qualifiedRefName.length() > MAX_FQ_REF_LENGTH) {
    throw new InvalidRefNameException(i18nService.createKeyedMessage("bitbucket.git.ref.qualified.name.too.long",
            MAX_FQ_REF_LENGTH),
            refName);
}

MAX_FQ_REF_LENGTH = 100

refName = bugfix/BIB-3781-_bib1837_-hunkchoice-stringkoord-throws-exception-if-lwert-is-out-of-bounds

qualifiedRefName = refs/heads/bugfix/BIB-3781-_bib1837_-hunkchoice-stringkoord-throws-exception-if-lwert-is-out-of-bounds

Still happening in 5.16.0.

It seems like I can't attach the screenshot to this image (@lbain).

I see that in Bitbucket version 5.9.1 this issue is not fixed.

We experienced this in Bitbucket version 5.13. It would be great if we could configure this restriction somehow.

Hello all,

I'm very sorry for my bad fix. I've since pushed a corrected one that will go out in the listed versions (5.9.1, 5.6.6, 5.7.4, 5.8.3) whenever they are next shipped. This will count the "/refs/heads" properly so should resolve the issue as described.

Sorry,
Lucy

Still happening in 5.7.0.

When creating a new branch sometimes following error message will be shown:

The ref name, once fully qualified, is limited to 100 characters

In this example the branch "FCQ-15441-fcx036-adapt-parameter-visibility-for-ejecttool-angle-and-angle-correction" is 86 characters long (with prefix 93) and when removing the last 11 characters everything works fine.

For the user this is highly confusing, because the validation text is wrong. If "/refs/heads/bugfix" is added into this calculation, then the limit that is shown has to be adapted (e.g. maximum allowed: 80 or whatever).

But maybe it would be easier if the branch name was truncated at the end to fit the validation requirements?

It means 105 characters

refs/head/bugfix/VP-29914-clone-vortex-editor-unable-to-connect-to-a-container-in-the-vehicle-system-for

@lbain, the title of the Jira is:

CLONE - Vortex Editor: Unable to connect to a container in the vehicle system for enabling/disabling a feature

The branch it tries to create in Bitbucket:

bugfix/VP-29914-clone-vortex-editor-unable-to-connect-to-a-container-in-the-vehicle-system-for

+ refs/head/ character count

Hi sylvain.giasson@cm-labs.com,

It should be that if (the character count of the branch) + (the character count of "bugfix/" (7)) is over 100 then you see that error. Could you share the full branch name that's being submitted in that image?

Thanks,
Lucy

Are you sure it is really fixed in version 5.6.0?  We run that exact version and still experience the issue...

Actually, it never did include the prefix in the validation. But since the validation was previously limited to 40 characters (and implemented in a way that could actually suggest a value longer than that 40 character limit given certain inputs), the combination would still never come close to the hard 100 limit the server applied. Now the combination can exceed the server limit.