Uploaded image for project: 'Bitbucket Cloud'
  1. Bitbucket Cloud
  2. BCLOUD-6290

Emoji in commit messages break layout

    XMLWordPrintable

    Details

      Description

      Emoji icons break the layout a bit, when used in commit messages.

      https://bitbucket.org/miloslevacic/bitbucket-bug-markdown-toc/commits/all

      Here's the repro'd bug (in a public repo created for issue BCLOUD-6273 which seems to be fixed now, so I'm going to use it for this to skip creating a new repo).

      Adding the following to the CSS seems to work for me

      .emoji {
          /* in addition to the already defined style: */
          position: relative;
          margin-top: -8px;
          top: 6px;
      }
      

      The margin-top first pulls the whole <div> content up 8px (which is probably the difference between the 14px font-size and the 22px height of the span.emoji), and the top pushes the icon back down to where it should be. (The position is obviously there to make top work).

      This seems about right for me (visually), but I didn't put much thought into it, so there might be a better solution.

        Attachments

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            milos.levacic1014833591 Milos Levacic
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: