Issue Summary

There are a few UI/UX issues with the comments filter on the commit page:

• The filter disappears if it is selected at first and the diff becomes empty
• It is difficult to interact with the comments filter buttons and not clear what the current filter status is

Steps to Reproduce

Disappearing filter:

1. Open a commit in Bitbucket with no comments.
2. Click on the filter by comments button. The diff is empty (as expected) but the comments filter disappears and the user has to reload the page to view the diff again.
3. The diff also has a misleading message that "there are no changed files in the commit."

Difficult UX:

1. Open a commit in Bitbucket with 1+ comments.
2. Click on the filter by comments button. The diff is filtered as expected but it is not clear what the current filter status is (all comments, my comments, no filter) or how to revert to no filter.

Expected Results

• The commit page shows UI option to filter by all comments, your comments, and no filter
• The diff updates according the filter
• If the filtered diff is empty, the message should be clear that the diff is empty when filtering for comments.

Actual Results

• The comments filter is difficult to interact with
• The diff updates according to the filter
• If the filtered diff is empty, the message misleadingly shows that "there are no changed files in the commit."

Workaround

• Reload the commit page