-
Bug
-
Resolution: Fixed
-
Medium
-
None
-
7
-
Severity 3 - Minor
-
13,532
-
Issue Summary
Removing reviewers from a PR is prohibited if they have approved or requested changes on the PR. This is as expected. The problem is that if a person has previously approved or requested changes, and then those are reset (based on branch permissions), the person cannot be removed from the PR, even though they have no current approval status.
Expected state: Only reviewers with current approval status (approve / request changes) are prevented from being removed from a PR. It should be possible to remove a reviewer with a previous approval status that has been reset based on branch permissions.
Steps to Reproduce
- User approves PR and reset PR approvals is enabled (this is a feature in branch permissions)
- Push new changes to the PR to reset approval
- Attempt to remove reviewer
Expected Results
Reviewer is removed
Actual Results
Error popup:
Something went wrong Error: You cannot remove reviewers with status
Workaround
Decline the existing PR and raise a new one.