Uploaded image for project: 'Bamboo Data Center'
  1. Bamboo Data Center
  2. BAM-456

Code change filenames from CVS branch have "Attic" in the path

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Medium Medium
    • 0.7.1
    • 0.6
    • Repository (CVS)
    • None

      Most of our checkins are to CVS branches where the repository records the change in the special "Attic" directory. This is propagating into Bamboo, where the ViewCVS/Fisheye links contain the "Attic/" path in them, thus they are broken. Could you filter file paths for the Attic and remove it?

          Form Name

            [BAM-456] Code change filenames from CVS branch have "Attic" in the path

            Hi Mark, the fix works great, but you forgot to remove "Attic" from the link text itself – only a cosmetic issue, but it'd be great if you cleaned it up. Thanks!

            Nick Sieger added a comment - Hi Mark, the fix works great, but you forgot to remove "Attic" from the link text itself – only a cosmetic issue, but it'd be great if you cleaned it up. Thanks!

            At any rate, thanks for the quick response and the fix! Looking forward to trying it.

            Nick Sieger added a comment - At any rate, thanks for the quick response and the fix! Looking forward to trying it.

            Mark, I know what the issue is. If you want, you could try it out.

            What we have is files that were only created on branches and don't actually have any revisions on the trunk.

            You should be able to reproduce like this:

            <go to some test directory>
            cvs tag -b test_branch
            cvs update -r test_branch
            touch test.txt
            cvs add test.txt
            cvs ci
            

            Here's example "cvs log" output for such a file:

            Working file: test.txt
            head: 1.1
            branch:
            locks: strict
            access list:
            symbolic names:
                    test_branch: 1.1.0.2
            keyword substitution: kv
            total revisions: 2;     selected revisions: 2
            description:
            ----------------------------
            revision 1.1
            date: 2006/11/21 14:52:20;  author: nsieger;  state: dead;
            branches:  1.1.2;
            file test.txt was initially added on branch test_branch.
            ----------------------------
            revision 1.1.2.1
            date: 2006/11/21 14:52:20;  author: nsieger;  state: Exp;  lines: +0 -0
            - adding a file on test_branch
            =============================================================================
            

            Nick Sieger added a comment - Mark, I know what the issue is. If you want, you could try it out. What we have is files that were only created on branches and don't actually have any revisions on the trunk. You should be able to reproduce like this: <go to some test directory> cvs tag -b test_branch cvs update -r test_branch touch test.txt cvs add test.txt cvs ci Here's example "cvs log" output for such a file: Working file: test.txt head: 1.1 branch: locks: strict access list: symbolic names: test_branch: 1.1.0.2 keyword substitution: kv total revisions: 2; selected revisions: 2 description: ---------------------------- revision 1.1 date: 2006/11/21 14:52:20; author: nsieger; state: dead; branches: 1.1.2; file test.txt was initially added on branch test_branch. ---------------------------- revision 1.1.2.1 date: 2006/11/21 14:52:20; author: nsieger; state: Exp; lines: +0 -0 - adding a file on test_branch =============================================================================

            MarkC added a comment -

            Nick,

            I can't reproduce your exact problem (ie on the branch). AFAIK, "/Attic" should really only appear if your file has been removed from CVS, so I'm not 100% what the problem is in your case.

            We have, however, made sure we removed the "/Attic" from the URL in 0.7 and any FishEye links with attic in it should now work.

            Cheers,

            Mark C

            MarkC added a comment - Nick, I can't reproduce your exact problem (ie on the branch). AFAIK, "/Attic" should really only appear if your file has been removed from CVS, so I'm not 100% what the problem is in your case. We have, however, made sure we removed the "/Attic" from the URL in 0.7 and any FishEye links with attic in it should now work. Cheers, Mark C

            MarkC added a comment -

            Nick,

            Thanks for pointing that out. We'll try to squeeze the change in for 0.7 for you

            Cheers,

            Mark C

            MarkC added a comment - Nick, Thanks for pointing that out. We'll try to squeeze the change in for 0.7 for you Cheers, Mark C

            Small screenshot of code changes screen

            Nick Sieger added a comment - Small screenshot of code changes screen

              mark@atlassian.com MarkC
              3a161090517b Nick Sieger
              Affected customers:
              0 This affects my team
              Watchers:
              0 Start watching this issue

                Created:
                Updated:
                Resolved: