Issue Summary

By default when plan is not having build expiry option ticked - then all is fine.

After start playing with changing various options on build expiry and then unchecking all checkbox - for some reason dslForPlan and java bamboo specs are still pertaining those configurations as they were selected.

Steps to Reproduce

1. Go to Plan
2. Click 'Other' tab
3. Check 'Override global build expiry configuration'
4. Enter 5 days, max builds: 5.
5. Uncheck 'Override global build expiry configuration'
6. Verify dsl / bamboo java specs

Expected Results

No additional buildExpiry configuration is present in java bamboo specs.

Actual Results

The below config is visible in java bamboo specs:

Bamboo specs:

                                .put("buildExpiryConfig", new MapBuilder()
                                    .put("period", "days")
                                    .put("expiryTypeBuildLog", "false")
                                    .put("labelsToKeep", "")
                                    .put("maximumBuildsToKeep", "5")
                                    .put("enabled", "true")
                                    .put("duration", "5")
                                    .put("expiryTypeNothing", "false")
                                    .put("expiryTypeResult", "false")
                                    .put("buildsToKeep", "")
                                    .build())

Dsl:

   buildExpiry(period:'days',duration:'5')

Workaround

Currently there is no known workaround for this behavior. A workaround will be added here when available

Partial Workaround:

1. Tick 'Override global build expiry configuration'
2. Tick 'Do not expire anything for this plan'
3. Save
4. Untick 'Do not expire anything for this plan'
5. Untick 'Override global build expiry configuration'
6. Save
7. It clears somehow configuration but dsl is different from bamboo specs and it should be gone at all.

                                    .build())
                                .put("buildExpiryConfig", new MapBuilder()
                                    .put("maximumBuildsToKeep", "5")
                                    .put("expiryTypeResult", "false")
                                    .build())

   buildExpiry(notExpire:'true',period:'days')