Disable signup does not remove Sign up button

Issue Summary

After disabling signup option, the Sign up button still exist if anonymous permission is enabled

Steps to Reproduce

1. Disable signup option at Administration >> Security >> Security settings
2. Enable Anonymous user permission at Administration >> Security >> Global permission
3. Disable Anonymous user permission in all Plan Configurations
4. Logout
5. Check if there is a Sign up button in the Bamboo Home page (instead of the top right)

Expected Results

Sign up button will not appear

Actual Results

• The top right Sign up button have disappeared
• The Sign up button in the Bamboo Home page still exist
  Clicking on this Sign up button will request user to login. After login, it will have error to access sign up page. User still unable to perform sign up

Workaround 1

Disable Anonymous user Global Permission

Workaround 2

1. Shutdown Bamboo
2. Edit the file <bamboo-install>/atlassian-bamboo/feature/dashboard/welcome-mat/welcome-mat.soy to remove the following lines:

                                       {if $showSignup}
                                           {call aui.buttons.button}
                                               {param text: getText('bamboo.banner.signup') /}
                                               {param tagName: 'a' /}
                                               {param extraClasses: 'aui-style' /} // hack - needed until we use ADG
                                               {param extraAttributes: [ 'href': contextPath() + '/signupUser!doDefault.action' ] /}
                                           {/call}
                                       {/if}
   

3. Restart Bamboo