-
Type:
Suggestion
-
Resolution: Unresolved
-
None
-
Component/s: Documentation (User)
We have shell scripts that check $BAMBOO_DEPLOY_ROLLBACK in a number of ways. I'd like to be confident that we're checking against the right value. I believe that a correct form is:
if [ "$bamboo_deploy_rollback" = "true" ];
and would like documentation to confirm that.
The documentation states that:
bamboo.deploy.rollback True if the release being deployed is older than the release being replaced.
From the source, I believe that this will specificially be true (lowercase), or false, and always present.
Could you update the documentation to make clear that it's upper/lowercase, and whether it will otherwise be set to false or missing? Ideally, formatted as <code> to make clear that it's a literal value.
FYI; the (incorrect?) tests we're using in other scripts are:
if $bamboo_deploy_rollback = True
which is bad sh syntax, but accidentally works because true will execute /bin/true, and:
if [ $bamboo_deploy_rollback = True ];
which is correct shell syntax, but case-sensitively assumes True, and will actually fail with true.