Uploaded image for project: 'Bamboo'
  1. Bamboo
  2. BAM-20489

Quarantine test stop plan branch trigger and branch creation for subsequent plans that use the same repository

    XMLWordPrintable

    Details

      Description

      Issue Summary

      When a test is quarantined, plan branch fails to trigger when it's created and logs an error (Error 1). Also if an attempt is made to create a plan branch manually, it creates the plan branch but an error modal is produced (Error 2).

      It will also stop plan branches being created for some other plans that use the same repository, but it is order dependant. Hitting the exception for one plan will stop the iterative creation process from looping through all plans.

      Steps to Reproduce

      1. Create a plan branch: when a new branch in the repository is created
      2. Create a test that fails
      3. Quarantine the failed test
      4. Create a branch in the git repository

      Expected Results

      A plan branch should be created in Bamboo and build triggered.
      All plans that have automatic branch detection on and use the repository should have the branch created.

      Actual Results

      The plan branch is created, but the build is not triggered. Log atlassian-bamboo.log shows;

      Error 1

      2019-06-19 14:34:32,822 ERROR [AtlassianEvent::0-BAM::EVENTS:pool-1-thread-2] [AsynchronousAbleEventDispatcher] There was an exception thrown trying to dispatch event [com.atlassian.stash.plugin.remote.event.StashBranchCreatedRemoteEvent@18f1f729[branchName=release/release-1.0,repositoryProject=DPPROJ,repositorySlug=performtest,committer=admin,sourceId=a5628572-d00a-3a40-b328-68404d5d4d0c,sourceUrl=http://localhost:7990]] from the invoker [SingleParameterMethodListenerInvoker{method=public void com.atlassian.bamboo.plugins.stash.events.BranchCreatedEventListener.onCreateRepositoryBranchEvent(com.atlassian.stash.plugin.remote.event.StashBranchCreatedRemoteEvent), listener=com.atlassian.bamboo.plugins.stash.events.BranchCreatedEventListener@28d2b56b}]
      
      2019-06-19 14:34:32,822 ERROR [AtlassianEvent::0-BAM::EVENTS:pool-1-thread-2] [AsynchronousAbleEventDispatcher] There was an exception thrown trying to dispatch event [com.atlassian.stash.plugin.remote.event.StashBranchCreatedRemoteEvent@18f1f729[branchName=release/release-1.0,repositoryProject=DPPROJ,repositorySlug=performtest,committer=admin,sourceId=a5628572-d00a-3a40-b328-68404d5d4d0c,sourceUrl=http://localhost:7990]] from the invoker [SingleParameterMethodListenerInvoker{method=public void com.atlassian.bamboo.plugins.stash.events.BranchCreatedEventListener.onCreateRepositoryBranchEvent(com.atlassian.stash.plugin.remote.event.StashBranchCreatedRemoteEvent), listener=com.atlassian.bamboo.plugins.stash.events.BranchCreatedEventListener@28d2b56b}]
      
      java.lang.RuntimeException: Can't clone quarantined test 'com.example.demo.DemoApplicationTests' for a new branch 'com.atlassian.bamboo.plan.branch.ChainBranchImpl@8eedd889' as its .getPlan() didn't return a Job object at 
      
         com.atlassian.event.internal.SingleParameterMethodListenerInvoker.invoke(SingleParameterMethodListenerInvoker.java:54) at 
         com.atlassian.event.internal.AsynchronousAbleEventDispatcher$1$1.run(AsynchronousAbleEventDispatcher.java:46) at 
         java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at 
         java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at 
         com.atlassian.bamboo.utils.BambooRunnables$1.run(BambooRunnables.java:48) at 

       Error 2

      An unexpected error has occurredjava.lang.IllegalStateException: Can't clone quarantined test 'com.example.demo.DemoApplicationTests' for a new branch 'com.atlassian.bamboo.plan.branch.ChainBranchImpl@8eedd88b' as its .getPlan() didn't return a Job object
      	at com.google.common.base.Preconditions.checkState(Preconditions.java:197)
      	at com.atlassian.bamboo.build.creation.ChainBranchCreationServiceImpl.cloneQuarantinedTestsFromMaster(ChainBranchCreationServiceImpl.java:364)
      	at com.atlassian.bamboo.build.creation.ChainBranchCreationServiceImpl.triggerCreationCompleteEvents(ChainBranchCreationServiceImpl.java:398)
      	at com.atlassian.bamboo.ww2.actions.branch.CreateChainBranch.execute(CreateChainBranch.java:103)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at java.lang.reflect.Method.invoke(Method.java:498)
      	at ognl.OgnlRuntime.invokeMethod(OgnlRuntime.java:899)
      	at ognl.OgnlRuntime.callAppropriateMethod(OgnlRuntime.java:1544)
      	at ognl.ObjectMethodAccessor.callMethod(ObjectMethodAccessor.java:68)
      	
      	..
      	at com.atlassian.bamboo.ww2.interceptors.SimpleConversionErrorInterceptor.intercept(SimpleConversionErrorInterceptor.java:64)
      	at com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:249)
      	at com.atlassian.bamboo.ww2.interceptors.BambooXsrfTokenInterceptor.doIntercept(BambooXsrfTokenInterceptor.java:47)
      	at com.atlassian.bamboo.ww2.interceptors.AbstractBambooInterceptor.lambda$intercept$0(AbstractBambooInterceptor.java:29)
      	at com.atlassian.bamboo.util.BambooProfilingUtils.withUtilTimerStack(BambooProfilingUtils.java:35)
      	at com.atlassian.bamboo.ww2.interceptors.AbstractBambooInterceptor.intercept(AbstractBambooInterceptor.java:28)
      	at com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:249)

      Plan branches are not created for any remaining plans with automatic branch creation on that were not checked before hitting this exception.

      Workaround

      From the Plan summary, navigate to the Quarantined tests tab, and click the Resume button to resume the test

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              mgardias Marcin Gardias
              Reporter:
              voseghale VICTOR-OSEGHALE
              Votes:
              5 Vote for this issue
              Watchers:
              17 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: