Summary

Bamboo upgrade continues despite upgrade task 51111 detecting unsupported MySQL version.

Environment

• MySQL

Steps to Reproduce

• Start Bamboo on a database from an unsupported version of MySQL (e.g. 5.1.67)

For upgrade task 60101 failure:

1. Import XML export from Bamboo 6.0.3 into a Bamboo 6.2.2 instance
2. Restart Bamboo

Expected Results

Database validation task 51111 fails and Bamboo does not start / proceed with upgrade. Correct error is communicated to UI.

Actual Results

1. Validation task succeeds

   2017-11-03 18:23:45,397 INFO [localhost-startStop-1] [BootstrapUpgradeManagerImpl] -------------------------------------------
   2017-11-03 18:23:45,397 INFO [localhost-startStop-1] [BootstrapUpgradeManagerImpl] 51111 : Verify DB compatibility (bootstrap)
   2017-11-03 18:23:45,397 INFO [localhost-startStop-1] [BootstrapUpgradeManagerImpl] -------------------------------------------
   2017-11-03 18:23:45,402 INFO [localhost-startStop-1] [DatabaseIsSupported] Testing compatibility of [MySQL] 5.1.67 (5.1.67) using JDBC driver [MySQL Connector Java] 5.1.0 (mysql-connector-java-5.1.38 ( Revision: fe541c166cec739c74cc727c5da96c1028b4834a )) with this version of Bamboo.
   2017-11-03 18:23:45,403 ERROR [localhost-startStop-1] [DatabaseIsSupported] Detected MYSQL version [MySQL] 5.1.67 (5.1.67), minimal supported version is 5.6.3
   2017-11-03 18:23:45,403 ERROR [localhost-startStop-1] [DatabaseIsSupported] Bamboo doesn't support MySQL version 5.1.67. Please check https://confluence.atlassian.com/display/BAMBOO/Supported+Platforms for more information.
   2017-11-03 18:23:45,403 INFO [localhost-startStop-1] [BootstrapUpgradeManagerImpl] Task 51111 completed successfully.
   

2. Upgrade task fails 60101 fails due to incompatibilities with the unsupported version of MySQL:

   2017-11-03 18:24:30,449 INFO [16-UpgradeTaskBackgroundThread:pool-31-thread-1] [AbstractUpgradeManager] -----------------------------------------------------------
   2017-11-03 18:24:30,449 INFO [16-UpgradeTaskBackgroundThread:pool-31-thread-1] [AbstractUpgradeManager] 60101 : Create unique index on agent assignment (bootstrap)
   2017-11-03 18:24:30,449 INFO [16-UpgradeTaskBackgroundThread:pool-31-thread-1] [AbstractUpgradeManager] -----------------------------------------------------------
   2017-11-03 18:24:30,455 INFO [16-UpgradeTaskBackgroundThread:pool-31-thread-1] [C3P0ConnectionProvider] HHH010002: C3P0 using driver: com.mysql.jdbc.Driver at URL: (...)
   2017-11-03 18:24:30,455 INFO [16-UpgradeTaskBackgroundThread:pool-31-thread-1] [C3P0ConnectionProvider] HHH10001001: Connection properties: (...)
   2017-11-03 18:24:30,455 INFO [16-UpgradeTaskBackgroundThread:pool-31-thread-1] [C3P0ConnectionProvider] HHH10001003: Autocommit mode: false
   2017-11-03 18:24:30,544 INFO [16-UpgradeTaskBackgroundThread:pool-31-thread-1] [C3P0ConnectionProvider] HHH10001007: JDBC isolation level: <unknown>
   2017-11-03 18:24:30,548 INFO [16-UpgradeTaskBackgroundThread:pool-31-thread-1] [AbstractPoolBackedDataSource] Initializing c3p0 pool... com.mchange.v2.c3p0.PoolBackedDataSource@cced2dc8 (...)
   2017-11-03 18:24:30,598 ERROR [16-UpgradeTaskBackgroundThread:pool-31-thread-1] [AbstractUpgradeManager] com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Duplicate key name 'ASSIGNMENT_UNIQUE'
   com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Duplicate key name 'ASSIGNMENT_UNIQUE'
   	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
   	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
   	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
   	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
   	at com.mysql.jdbc.Util.handleNewInstance(Util.java:404)
   	at com.mysql.jdbc.Util.getInstance(Util.java:387)
   	at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:939)
   	at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3878)
   	at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3814)
   	at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2478)
   	at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2625)
   	at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2547)
   	at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2505)
   	at com.mysql.jdbc.StatementImpl.executeInternal(StatementImpl.java:840)
   	at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:740)
   	at com.mchange.v2.c3p0.impl.NewProxyStatement.execute(NewProxyStatement.java:75)
   	at com.atlassian.bamboo.utils.db.JdbcUtils.execute(JdbcUtils.java:60)
   	at com.atlassian.bamboo.utils.db.AbstractDbmsBean.createUniqueConstraint(AbstractDbmsBean.java:220)
   	at com.atlassian.bamboo.upgrade.tasks.v6_1.UpgradeTask60101AddUniqueIndex.lambda$doUpgrade$1(UpgradeTask60101AddUniqueIndex.java:51)
   	at com.atlassian.bamboo.upgrade.AbstractBootstrapUpgradeTask.withDatabaseConnection(AbstractBootstrapUpgradeTask.java:65)
   	at com.atlassian.bamboo.upgrade.tasks.v6_1.UpgradeTask60101AddUniqueIndex.doUpgrade(UpgradeTask60101AddUniqueIndex.java:50)
   	at com.atlassian.bamboo.upgrade.AbstractUpgradeManager.runUpgradeTask(AbstractUpgradeManager.java:154)
   	at com.atlassian.bamboo.upgrade.UpgradeManagerImpl.doUpgrade(UpgradeManagerImpl.java:132)
   	at com.atlassian.bamboo.upgrade.UpgradeLauncher.lambda$upgradeAndStartBamboo$0(UpgradeLauncher.java:104)
   	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
   	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
   	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
   	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
   	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
   	at com.atlassian.bamboo.utils.BambooRunnables$1.run(BambooRunnables.java:47)
   	at com.atlassian.bamboo.security.ImpersonationHelper.runWith(ImpersonationHelper.java:26)
   	at com.atlassian.bamboo.security.ImpersonationHelper.runWithSystemAuthority(ImpersonationHelper.java:17)
   	at com.atlassian.bamboo.security.ImpersonationHelper$1.run(ImpersonationHelper.java:41)
   	at java.lang.Thread.run(Thread.java:745)
   

Resolution

• Upgrade MySQL to a supported version.