Move buildNumber from bamboo.cfg.xml to a database property

Summary

Risks of migration and upgrade failure due to property (e.g <buildNumber />) being stored in <bamboo-home>/bamboo.cfg.xml filesystem instead of database.

Scenario

The property in question is responsible to let Bamboo know which upgrade tasks should be executed during the startup process. Lets review the following scenario:

• Bamboo version A (connected to Production database)
  <buildNumber>123456</buildNumber>
  <property name="hibernate.connection.url">jdbc:mysql://localhost/bambooPROD?autoReconnect=true</property>
• Bamboo version B (new installation)
  <buildNumber>999999</buildNumber>
  <property name="hibernate.connection.url">jdbc:mysql://localhost/bambooTEMP?autoReconnect=true</property>

When upgrading Bamboo (from version A to version B) administrators must not edit <bamboo-home>/bamboo.cfg.xml from new Bamboo installation (version B) to point to the Bamboo's database (production data) because the <buildNumber>999999</buildNumber> in the new installation is more recent than version A.

Suggestion

Some properties (e.g <buildNumber />) in <bamboo-home>/bamboo.cfg.xml should be moved/stored in the database, minimising the risks of unsuccessful Bamboo's migration or upgrade.