Uploaded image for project: 'Bamboo Data Center'
  1. Bamboo Data Center
  2. BAM-17847

Dont remove logs from failed deployments if is included by Minimum to keep

      Summary

      Failed logs can be extremely important as the logs for a successful deployment. Bamboo seems to expire these currently even when a deployment falls under "Minimum Deployments To Keep".

      Environment

      Bamboo 5.12.X
      Bamboo 5.9.X

      Steps to Reproduce

      1. Set the global expiration settings to:
      Expire After: 0 days
      Min builds to keep: 3
      Min deployments to keep: 3
      2. Run a few deployments, then for the last 3 have one fail and 1 sucessful.
      3. Manually run Expiraiton.

      Expected Results

      Most customers would expect that all logs should be preserved as the deployments have been preserved.

      Actual Results

      Deployments beyond the minimal 3 are correctly deleted. However, the logs for the failed builds are cleared - but the successful build is kept.

      Workaround

      Not ideal, but extend the value for Expire After the logs for longer.

            [BAM-17847] Dont remove logs from failed deployments if is included by Minimum to keep

            Marcin Walerianczyk made changes -
            Resolution New: Fixed [ 1 ]
            Status Original: Waiting for Release [ 12075 ] New: Closed [ 6 ]
            Marcin Gardias made changes -
            Status Original: In Progress [ 3 ] New: Waiting for Release [ 12075 ]
            Marcin Gardias made changes -
            Fix Version/s New: 7.0.3 [ 91527 ]
            Marcin Gardias made changes -
            Assignee New: Marcin Gardias [ mgardias ]
            Marcin Gardias made changes -
            Status Original: Short Term Backlog [ 12074 ] New: In Progress [ 3 ]

            Marcin Gardias added a comment - - edited

            Hi,

            Unfortunately, this is not a straightforward fix. Our intent was to preserve n latest successful deployments. We cannot change the meaning of the option now to n latest any deployments, as this would break the existing behavior for those that rely on it.

            IMO the solution is to introduce a second number, so the expiry would be able to keep n successful and m of any results.

            We are going to add the feature to a 7.0.x point release. Default value for the new setting will be '0' (in order to preserve the current behavior), so after installing the fix, you'll need to set the value manually.

             

            Marcin Gardias added a comment - - edited Hi, Unfortunately, this is not a straightforward fix. Our intent was to preserve n latest successful deployments. We cannot change the meaning of the option now to n latest any deployments, as this would break the existing behavior for those that rely on it. IMO the solution is to introduce a second number, so the expiry would be able to keep n successful and m of any results. We are going to add the feature to a 7.0.x point release. Default value for the new setting will be '0' (in order to preserve the current behavior), so after installing the fix, you'll need to set the value manually.  
            Pawel Skierczynski made changes -
            Status Original: Long Term Backlog [ 12073 ] New: Short Term Backlog [ 12074 ]
            Pawel Skierczynski made changes -
            Status Original: Gathering Impact [ 12072 ] New: Long Term Backlog [ 12073 ]
            Pawel Skierczynski made changes -
            Status Original: Needs Triage [ 10030 ] New: Gathering Impact [ 12072 ]
            Monique Khairuliana (Inactive) made changes -
            Workflow Original: Bamboo Workflow 2016 v1 - Restricted [ 1592013 ] New: JAC Bug Workflow v3 [ 3386219 ]
            Status Original: Open [ 1 ] New: Needs Triage [ 10030 ]

              mgardias Marcin Gardias
              nhickey Neil Hickey
              Affected customers:
              12 This affects my team
              Watchers:
              10 Start watching this issue

                Created:
                Updated:
                Resolved: