Uploaded image for project: 'Bamboo Data Center'
  1. Bamboo Data Center
  2. BAM-13005

Improve abstract class ResultLabelEvent

XMLWordPrintable

    • Icon: Suggestion Suggestion
    • Resolution: Fixed
    • 5.0
    • None
    • None

    • Our product teams collect and evaluate feedback from a number of different sources. To learn more about how we use customer feedback in the planning process, check out our new feature policy.

      The class com.atlassian.bamboo.event.ResultLabelEvent takes a com.atlassian.user.User in the constructor.

      However, the class members only store the :

      private final String username;

      with a getUsername() method.

      With this setup the ResultLabelEvent essentially drops the other User-related fields passed to the constructor. If you are writing plugins and write a Listener that catches the ResultLabelEvent it would be REALLY useful to get the other fields in the User object other than just the Username without having to inject a user manager and re-lookup the User object using the username.

      I would vote for a private member :

      private final User user;

      with a getter of :

      public User getUser(){}

      This would allow the subclasses ResultLabelAddedEvent and ResultLabelRemovedEvent access to the User object instead of JUST the Username String.

        1. ResultLabelEvent.java
          2 kB

            [BAM-13005] Improve abstract class ResultLabelEvent

            Katherine Yabut made changes -
            Workflow Original: JAC Suggestion Workflow [ 3015589 ] New: JAC Suggestion Workflow 3 [ 3601854 ]
            Status Original: RESOLVED [ 5 ] New: Closed [ 6 ]
            Owen made changes -
            Workflow Original: Confluence Workflow - Public Facing v4 [ 2697991 ] New: JAC Suggestion Workflow [ 3015589 ]
            Owen made changes -
            Assignee Original: PiotrA [ pstefaniak ]
            Issue Type Original: Improvement [ 4 ] New: Suggestion [ 10000 ]
            Owen made changes -
            Workflow Original: Bamboo Workflow 2016 v1 [ 1406590 ] New: Confluence Workflow - Public Facing v4 [ 2697991 ]
            Marek Went (Inactive) made changes -
            Workflow Original: Bamboo Workflow 2014 v2 [ 606739 ] New: Bamboo Workflow 2016 v1 [ 1406590 ]
            James Dumay made changes -
            Workflow Original: Bamboo Workflow 2014 [ 594236 ] New: Bamboo Workflow 2014 v2 [ 606739 ]
            James Dumay made changes -
            Workflow Original: Bamboo Workflow 2010 [ 514653 ] New: Bamboo Workflow 2014 [ 594236 ]
            PiotrA made changes -
            Remote Link New: This issue links to "+core+ Bamboo › CI Tests +on stash+ › BAM-13005 (Tardigrade Server)" [ 46534 ]
            PiotrA made changes -
            Fix Version/s New: 5.0 [ 29794 ]
            Resolution New: Fixed [ 1 ]
            Status Original: Open [ 1 ] New: Resolved [ 5 ]

            PiotrA added a comment -

            note to self: merged to 5.0 branch with 18b1d35

            PiotrA added a comment - note to self: merged to 5.0 branch with 18b1d35

              Unassigned Unassigned
              ef602377c686 Adam Myatt
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: