Uploaded image for project: 'Bamboo Data Center'
  1. Bamboo Data Center
  2. BAM-1118

FishEye link from Perforce project causes exception

      Just deployed 1.0.4, which has quite a few Perforce-related fixes (many thanks for these!)

      Spotted a problem when you follow the "full change details" link, ie to .../commit on a Perforce project, which is where you get "Expression file.revision is undefined on line 370, column 127 in lib/components.ftl". I've attached the trace from the page to this issue.

      Is there any chance that the change made for BAM-1096 has broken the functionality fixed in BAM-823?

      Many thanks,

      David

        1. BAM-1118-logs.zip
          193 kB
        2. components.ftl
          70 kB
        3. perforce-fisheye.txt
          13 kB

            [BAM-1118] FishEye link from Perforce project causes exception

            bmccoy added a comment -

            Hi David,

            I have moved the revision number problem to a new issue.
            You can track it here: http://jira.atlassian.com/browse/BAM-1138

            Also, the next release should be very soon. So you can grab the actual fixes.

            Cheers
            Brydie

            bmccoy added a comment - Hi David, I have moved the revision number problem to a new issue. You can track it here: http://jira.atlassian.com/browse/BAM-1138 Also, the next release should be very soon. So you can grab the actual fixes. Cheers Brydie

            Brydie,

            Thanks for the quick response.

            The new components.ftl so very nearly works. No errors any more, but the (re)vision numbers aren't matching with perforce.

            For example, the diff link looks like:

            http://hostname/path?content-type=text/vnd.viewcvs-markup&r1=3&r2=4

            where it should look like

            http://hostname/path?content-type=text/vnd.viewcvs-markup&r1=133611&r2=133753

            A similar problem happens with the "(version n)" link; it's got the wrong revision number in the text and the href, ie 4 instead of 133753.

            Hopefully an easy one for you guys to fix.

            Cheers,

            David

            David Dunwoody added a comment - Brydie, Thanks for the quick response. The new components.ftl so very nearly works. No errors any more, but the (re)vision numbers aren't matching with perforce. For example, the diff link looks like: http://hostname/path?content-type=text/vnd.viewcvs-markup&r1=3&r2=4 where it should look like http://hostname/path?content-type=text/vnd.viewcvs-markup&r1=133611&r2=133753 A similar problem happens with the "(version n)" link; it's got the wrong revision number in the text and the href, ie 4 instead of 133753. Hopefully an easy one for you guys to fix. Cheers, David

            bmccoy added a comment -

            Hi David,

            I have actually have managed to replicate the problem. It seems that when the comments are more than 2 lines long Bamboo reads incorrect lines as files. Unfortunatey this issue only became visible when we enabled the web urls.

            I have attached a patch that will prevent bamboo from erroring. If you replace the components.ftl file in Bamboo\webapp\lib with the attached file this will stop it from crashing on you. Otherwise, you could just turn off the web url for the moment.

            We will add an upgrade task in the next release to remove the unwanted files as well as add the fix so this doesn't happen again.

            Apologies for this,
            Brydie

            bmccoy added a comment - Hi David, I have actually have managed to replicate the problem. It seems that when the comments are more than 2 lines long Bamboo reads incorrect lines as files. Unfortunatey this issue only became visible when we enabled the web urls. I have attached a patch that will prevent bamboo from erroring. If you replace the components.ftl file in Bamboo\webapp\lib with the attached file this will stop it from crashing on you. Otherwise, you could just turn off the web url for the moment. We will add an upgrade task in the next release to remove the unwanted files as well as add the fix so this doesn't happen again. Apologies for this, Brydie

            build and error log snippets

            David Dunwoody added a comment - build and error log snippets

            I've attached two log snippets in BAM-1118-logs.zip - one from the build execution, and one from viewing the commit page.

            This is happening for all builds, and this is on builds carried out on 1.0.4, with (at least) the previous build also on 1.0.4. I've also reindexed the build results, in case that was needed.

            David Dunwoody added a comment - I've attached two log snippets in BAM-1118 -logs.zip - one from the build execution, and one from viewing the commit page. This is happening for all builds, and this is on builds carried out on 1.0.4, with (at least) the previous build also on 1.0.4. I've also reindexed the build results, in case that was needed.

            bmccoy added a comment -

            Hi David,

            I've had a look and the links seem to work on my instance. So i'm thinking that perhaps there was a problem when the changes were detected. Would you be able to attach the logs for when that particular build was executed.

            Just to clarify, does it happen for all the builds or just that particular one?
            Also, was this build before or after you upgraded to 1.0.4?

            Thanks,
            Brydie

            bmccoy added a comment - Hi David, I've had a look and the links seem to work on my instance. So i'm thinking that perhaps there was a problem when the changes were detected. Would you be able to attach the logs for when that particular build was executed. Just to clarify, does it happen for all the builds or just that particular one? Also, was this build before or after you upgraded to 1.0.4? Thanks, Brydie

              Unassigned Unassigned
              38c857f87151 David Dunwoody
              Affected customers:
              0 This affects my team
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: