jndi-jdbc jndi-server-name directions in entityengine.xml is not correct for jboss and external database

Guys,

for non HSQL, entityengine.xml currently lists for the datasource (example)

    <datasource name="defaultDS" field-type-name="mysql"
      helper-class="org.ofbiz.core.entity.GenericHelperDAO"
      check-on-start="true"
      use-foreign-keys="false"
      use-foreign-key-indices="false"
      check-fks-on-start="false"
      check-fk-indices-on-start="false"
      add-missing-on-start="true"
      check-indices-on-start="true">
        <jndi-jdbc jndi-server-name="default" jndi-name="java:/DefaultDS"/>
<!-- Orion format: <jndi-jdbc jndi-server-name="default" jndi-name="jdbc/JiraDS"/> -->
<!-- JBoss format: <jndi-jdbc jndi-server-name="default" jndi-name="java:/DefaultDS"/> -->
<!-- Weblogic format: <jndi-jdbc jndi-server-name="default" jndi-name="JiraDS"/> -->

If you configure for non-HSQL and follow the jboss4 docs, it advises, correctly, to configure the jndi-name as java:/JiraDS, yet in the XML flat file itself, it says

<!-- JBoss format: <jndi-jdbc jndi-server-name="default" jndi-name="java:/DefaultDS"/> -->

Which is only valid if you use HSQL; HSQL is pre-configured at DefaultDS in the JNDI tree, but if you use non-HSQL, the docs direct you to configure a JNDI element at "java:/JiraDS".

Jboss tries to acquire the JDBC driver via JNDI at JiraDS (as configured in server/default/deploy/jira-ds.xml), but fails because OfBiz has already registered it to DefaultDS

This is an expensive bug to debug from a support perspective, since we don't strictly support Jboss.

Please see JSP-26808 for backstory.

Cheers