Uploaded image for project: 'Jira Data Center'
  1. Jira Data Center
  2. JRASERVER-13066

Worklog Creation not easily extensible.

    XMLWordPrintable

Details

    • We collect Jira feedback from various sources, and we evaluate what we've collected when planning our product roadmap. To understand how this piece of feedback will be reviewed, see our Implementation of New Features Policy.

    Description

      Migrating Kaamelot to JIRA 3.10, I discovered two main things :

      • JIRA Architecture is more and more mature, and your code may inspire a lot of developper
      • But it appears that the philosphy of Extensibility is not followed by all JIRA developper ...

      In our previous exchange (mail from Dylan, the 15 May), it was plan that I will create some listener to catch Update and Delete events on Worklog.
      It was a good idea, but interesting only for Delete event.

      For Create and Update events, I do have to extends these actions in order to be able to retrieve the entered WorklogType (from Portlet through DWR and in overriden JSP) and save it in JIRAWORKLOG table (now WorklogExt OFBiz Entity).

      Finally, I decided to extend the 3 actions ...

      From AJAX Portlet From overriden JSP From Default JSP
      ExtendedCreateWorklogForAjax ExtendedCreateWorklog CreateWorklog
      ExtendedUpdateWorklogForAjax ExtendedUpdateWorklog UpdateWorklog
      ExtendedDeleteWorklogForAjax ExtendedDeleteWorklog DeleteWorklog

      Although, in my answer of 15 May to Dylan (cc Tim and Jason), I mentionned some remarks concerning :

      ...
      Concerning Service / Manager / Store and Worklog Action :
      As you have perhaps saw in Kaamelot, I have often make extends of existing Manager or Actions, and often duplicate existing method, which have private qualifier.
      Is it possible to provide Manager and Action with more protected qualifier in order to avoid such duplication ?
      ...

      for the Create action, the CreateWorklog class delegates Worklog creation to the WorklogService, but the attribut worklog in CreateWorklog is :
      - never updated after creation
      - not accessible : No Accessor even protected.

      In order to continue my migration, I have made a Hack (See attachment).

      May you integrate my hack or provide me another way to extend this action.

      Rgs
      Vincent

      Attachments

        Activity

          People

            Unassigned Unassigned
            5d77aaa81033 Vincent Thoulé
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 2h
                2h
                Remaining:
                Remaining Estimate - 2h
                2h
                Logged:
                Time Spent - Not Specified
                Not Specified